-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28370 Set updateTs
on default UserQuotaState
#5686
Conversation
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
ee066d6
to
b603cb3
Compare
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Test failures here look unrelated. |
💔 -1 overall
This message was automatically generated. |
Looks like my test is flappy, I can investigate early next week |
💔 -1 overall
This message was automatically generated. |
Oh, I just forgot the @ClassRule. Pushing a fix now |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…#5686) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…frequently (apache#5686) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…frequently (apache#5686) (#83) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
In #5666 we introduced default user quotas, but I accidentally called UserQuotaState's default constructor rather than passing in the current timestamp. The consequence is that we're constantly refreshing these default user quotas, and this can be a bottleneck for horizontal cluster scalability.
We have deployed this to a cluster with thousands of unique quota users and verified that the refresh workload was significantly reduced.
@bbeaudreault @hgromer @eab148 @bozzkar