-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28183 It's impossible to re-enable the quota table if it gets d… #5691
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
try { | ||
admin.enableTable(QuotaUtil.QUOTA_TABLE_NAME); | ||
} catch (Exception ex) { | ||
LOG.error("", ex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message is empty and we have assertion message, se we may not need a log message here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
+ "' is disallowed due to a violated space quota."); | ||
// skip checking quotas for hbase:quota table, see: | ||
// https://issues.apache.org/jira/browse/HBASE-28183 | ||
if (!tableName.equals(QuotaUtil.QUOTA_TABLE_NAME)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's extend this to all system tables. I think you can do isSystemTable.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified the check to isSystemTable
@chandrasekhar-188k Any update? |
76ccf0a
to
6eed845
Compare
review comments fixed , please check again |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The UT failure is not related to the code changes in this MR, it looks like a known existing failure. |
…isabled (#5691) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
…isabled (#5691) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
…isabled (#5691) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
…isabled (#5691) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
…isabled (apache#5691) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
…isabled