HBASE-28415 Remove Curator dependency from hbase-endpoint #5738

stoty · 2024-03-04T05:18:59Z

No description provided.

stoty · 2024-03-04T05:20:02Z

This is the hbase-endpoint dependency cleanup, split from HBASE-28411, as discussed, @Apache9 .

Apache-HBase · 2024-03-04T05:40:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 4s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	4m 52s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		19m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5738
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux b6a9b8d1b6c6 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-04T05:42:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 53s	hbase-endpoint in the patch passed.
		21m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5738
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 71d69c3e5715 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/testReport/
Max. process+thread count	1525 (vs. ulimit of 30000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-04T05:42:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 23s	hbase-endpoint in the patch passed.
		21m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5738
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b3662c706606 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/testReport/
Max. process+thread count	1506 (vs. ulimit of 30000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-04T05:43:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 16s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 57s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 32s	hbase-endpoint in the patch passed.
		23m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5738
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux af086cf25eb9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/testReport/
Max. process+thread count	1385 (vs. ulimit of 30000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5738/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-03-06T04:15:55Z

Do we know why we add this dependency here? Does remove this dependency in pom actually remove the curator dependency? Maybe we still have transitive dependency on curator?

stoty · 2024-03-06T06:57:54Z

A test has erronously used Curator's shaded Guava, and in a previous cleanup it has been added as an explicit dependency to avoid undeclared direct dependencies.
Later on the curator Guava usage was replaced with the correct one, and the curator shaded Guava was banned, but the dependency has not been removed.

We still have a transitive Curator dependency coming in via Hadoop-common, so most packages do have a transitive Curator dependency.

Transitive-only dependencies should not be declared as explicit dependencies though.

Apache9 · 2024-03-06T07:13:27Z

Was wondering whether we could just exclude the curator dependency as I do not think we rely on the features which depend on curator in hadoop-common...

Could test it later.

stoty · 2024-03-06T08:14:09Z

I think we could, as curator users should declare their own dependencies.

However, I don't think filtering individual transitive dependencies (and keeping those up to date) is a path we would want to take - unless we must for some reason.

I think the best solution is excluding Hadoop and its transitve dependencies from the assembly completely, and depending on an external Hadoop install.

taklwu

LGTM

Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>

HBASE-28415 Remove Curator dependency from hbase-endpoint

413ceb1

apurtell approved these changes Mar 4, 2024

View reviewed changes

Apache9 approved these changes Mar 6, 2024

View reviewed changes

taklwu approved these changes Mar 7, 2024

View reviewed changes

taklwu merged commit 643128f into apache:master Mar 7, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28415 Remove Curator dependency from hbase-endpoint #5738

HBASE-28415 Remove Curator dependency from hbase-endpoint #5738

stoty commented Mar 4, 2024

stoty commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache9 commented Mar 6, 2024

stoty commented Mar 6, 2024

Apache9 commented Mar 6, 2024

stoty commented Mar 6, 2024

taklwu left a comment

HBASE-28415 Remove Curator dependency from hbase-endpoint #5738

HBASE-28415 Remove Curator dependency from hbase-endpoint #5738

Conversation

stoty commented Mar 4, 2024

stoty commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache9 commented Mar 6, 2024

stoty commented Mar 6, 2024

Apache9 commented Mar 6, 2024

stoty commented Mar 6, 2024

taklwu left a comment

Choose a reason for hiding this comment