HBASE-26192 Master UI hbck should provide a JSON formatted output option #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @virajjasani @apurtell @ndimiduk Can I get review on this JIRA? (I have tried to include all the comments mentioned in the PR #4470 ) |
|
🎊 +1 overall
This message was automatically generated. |
|
Endpoint list for each inconsistencies : Orphan Region on FS : Here is Sample Output for |
ranganathg
reviewed
Mar 22, 2024
| private final HbckRegionDetails region1; | ||
| private final HbckRegionDetails region2; | ||
|
|
||
| public HbckOverlapRegions(HbckRegionDetails overlapRegion1, HbckRegionDetails overlapRegion2) { |
There was a problem hiding this comment.
this can be region1, region2 as well?
ranganathg
reviewed
Mar 22, 2024
| } | ||
|
|
||
| @GET | ||
| @Path("/orphan_regions_on_fs") |
There was a problem hiding this comment.
I read at places using hyphens is a recommended approach in REST APIs - https://restfulapi.net/resource-naming/
ranganathg
reviewed
Mar 22, 2024
| final String response = | ||
| classRule.getTarget().path("region_holes").request(MediaType.APPLICATION_JSON_TYPE) | ||
| .header("X-Jersey-Tracing-Accept", true).get(String.class); | ||
| assertThat(response, allOf(startsWith("{\"data\":["), endsWith("]}"))); |
There was a problem hiding this comment.
instead of only checking for starts with "data". can we have some mocks to return a list of objects and validate if the response is proper?
similarly at other places too.
There was a problem hiding this comment.
Done. Check 8177556
|
LGTM |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
Mar 26, 2024
| .register(ResponseEntityMapper.class).register(GsonSerializationFeature.class) | ||
| .register(new MasterFeature(master)) | ||
|
|
||
| // devs: enable TRACING to see how jersey is dispatching to resources. |
There was a problem hiding this comment.
Nice, thanks for adding this note.
| * The root object exposing hbck.jsp page as JSON Output. | ||
| */ | ||
| @Path("hbck-metrics") | ||
| @Produces({ MediaType.APPLICATION_JSON }) |
There was a problem hiding this comment.
Can we add support for XML here too? (Is that MediaType.APPLICATION_XML?) Should be as simple as that. Jersey will choose according to the contents of the client's Accept header.
There was a problem hiding this comment.
Based on my understanding from #4177 by @ndimiduk and limited understanding of JERSEY, We would have to implement something similar to https://github.com/apache/hbase/tree/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/gson for XML too. And that would be an another JIRA itself.
@ndimiduk What do you think?
d-c-manning
approved these changes
Mar 29, 2024
|
|
||
| private static final MiniClusterRule miniClusterRule = MiniClusterRule.newBuilder() | ||
| .setMiniClusterOption( | ||
| StartTestingClusterOption.builder().numZkServers(3).numMasters(3).numDataNodes(3).build()) |
There was a problem hiding this comment.
do you need 3 servers, or would the default 1 be good enough?
Suggested change
| StartTestingClusterOption.builder().numZkServers(3).numMasters(3).numDataNodes(3).build()) | |
| StartTestingClusterOption.builder().build()) |
There was a problem hiding this comment.
I have used similar configs from other tests for number of master and regionserver. I will look into more tests to see if it's beneficial to reduce number HM/RS and create JIRA if it's helpful.
ranganathg
approved these changes
Apr 1, 2024
|
No further comments, going to merge. Thank you @mihir6692 for the contribution |
asfgit
pushed a commit
that referenced
this pull request
Apr 8, 2024
…ion (#5772) Signed-off-by: Andrew Purtell <apurtell@apache.org>
mnpoonia
pushed a commit
to mnpoonia/hbase
that referenced
this pull request
Apr 24, 2024
…ion (apache#5772) Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/hbck/hbck-metrics/will provide entire HBCK Report in JSON Format. Also each inconsistency can be requested separately using their endpoints.Endpoint list for each inconsistencies :
Orphan Region on FS :
/hbck/hbck-metrics/orphan-regions-on-fsOrphan Region on RS :
/hbck/hbck-metrics/orphan-egions-on-rsInconsistent Regions :
/hbck/hbck-metrics/inconsistent-regionsRegion Holes :
/hbck/hbck-metrics/region-holesRegion Overlaps :
/hbck/hbck-metrics/region-overlapsUnknown Servers :
/hbck/hbck-metrics/unknown-serversEmpty Region Info :
/hbck/hbck-metrics/empty-regioninfo