Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28470 Fix typo in Java method comment #5786

Merged
merged 1 commit into from
Apr 18, 2024
Merged

HBASE-28470 Fix typo in Java method comment #5786

merged 1 commit into from
Apr 18, 2024

Conversation

voztaka
Copy link
Contributor

@voztaka voztaka commented Mar 29, 2024

The java method comment contains a typo.

The comment incorrectly states "Region name to assign" instead of "Region name to unassign".

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 44s master passed
+1 💚 compile 0m 19s master passed
+1 💚 shadedjars 5m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 17s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 30s the patch passed
+1 💚 compile 0m 20s the patch passed
+1 💚 javac 0m 20s the patch passed
+1 💚 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 16s the patch passed
_ Other Tests _
+1 💚 unit 1m 20s hbase-client in the patch passed.
20m 2s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5786
Optional Tests javac javadoc unit shadedjars compile
uname Linux 261e0399e116 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9adca10
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/testReport/
Max. process+thread count 298 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 50s master passed
+1 💚 compile 0m 25s master passed
+1 💚 shadedjars 6m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 12s the patch passed
+1 💚 compile 0m 30s the patch passed
+1 💚 javac 0m 30s the patch passed
+1 💚 shadedjars 6m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 18s the patch passed
_ Other Tests _
+1 💚 unit 2m 9s hbase-client in the patch passed.
27m 4s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5786
Optional Tests javac javadoc unit shadedjars compile
uname Linux aaef60e068ff 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9adca10
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/testReport/
Max. process+thread count 297 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 34s master passed
+1 💚 compile 0m 33s master passed
+1 💚 shadedjars 7m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 26s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 0m 28s the patch passed
+1 💚 javac 0m 28s the patch passed
+1 💚 shadedjars 7m 4s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s the patch passed
_ Other Tests _
+1 💚 unit 1m 56s hbase-client in the patch passed.
28m 56s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5786
Optional Tests javac javadoc unit shadedjars compile
uname Linux f05ba8c3b374 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9adca10
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/testReport/
Max. process+thread count 329 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 46s master passed
+1 💚 compile 1m 19s master passed
+1 💚 checkstyle 0m 31s master passed
+1 💚 spotless 1m 9s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 5s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 23s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 checkstyle 0m 21s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 2s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 0m 57s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 20s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
34m 10s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5786
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux ee8954586927 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9adca10
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5786/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit a34b4bc into apache:master Apr 18, 2024
1 check passed
Apache9 pushed a commit that referenced this pull request Apr 18, 2024
@voztaka @Apache9
HBASE-28470 Fix typo in Java method comment (#5786)
05c533b 
Co-authored-by: voztaka <you@example.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit a34b4bc)
Apache9 pushed a commit that referenced this pull request Apr 18, 2024
@voztaka @Apache9
HBASE-28470 Fix typo in Java method comment (#5786)
0f9378f 
Co-authored-by: voztaka <you@example.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit a34b4bc)
Apache9 pushed a commit that referenced this pull request Apr 18, 2024
@voztaka @Apache9
HBASE-28470 Fix typo in Java method comment (#5786)
1f36099 
Co-authored-by: voztaka <you@example.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit a34b4bc)
Apache9 pushed a commit that referenced this pull request Apr 18, 2024
@voztaka @Apache9
HBASE-28470 Fix typo in Java method comment (#5786)
2a7ca3d 
Co-authored-by: voztaka <you@example.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit a34b4bc)
Apache9 pushed a commit that referenced this pull request Apr 18, 2024
@voztaka @Apache9
HBASE-28470 Fix typo in Java method comment (#5786)
8deb58a 
Co-authored-by: voztaka <you@example.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit a34b4bc)
mnpoonia pushed a commit to mnpoonia/hbase that referenced this pull request Apr 24, 2024
@voztaka @mnpoonia
HBASE-28470 Fix typo in Java method comment (apache#5786)
5ea3533 
Co-authored-by: voztaka <you@example.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vineet4008 vineet4008 vineet4008 approved these changes

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@voztaka @Apache-HBase @Apache9 @vineet4008