HBASE-28483 backup merge fails on bulkloaded hfiles #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Ok so the problem here is that the Merge job sets the input dirs to table dirs:
backupIT/backup_1712319710829/default/table-false
backupIT/backup_1712319719106/default/table-false
Typically HFileInputFormat expects the input dirs to be region dirs like:
backupIT/backup_1712319710829/default/table-false/<regionname>
backupIT/backup_1712319719106/default/table-false/<regionname>
... etc, for each region in each table
In which case a region dir contains a column dir, and so it needed to handle that and does 1 level of "recursion".
But in the case of merge, the input dir is the table dir and it needs to do 2 levels of recursion.
I'm a little on the fence about whether this fix should be in HFileInputFormat or actually in MapReduceHFileSplitterJob. In the latter case we could list the backup dirs and add the regions within to the inputs, so that we honor the existing contract of HFileInputFormat.
That said I think for now I'm leaning towards this being the ok path, so we can leave it. There might be other benefits as well.
| @@ -155,16 +154,23 @@ protected List<FileStatus> listStatus(JobContext job) throws IOException { | |||
| // since HFiles are written to directories where the | |||
| // directory name is the column name | |||
There was a problem hiding this comment.
The comment here is out of date relative to the implementation now. It would be good to update it about the case where sometimes it might need to recurse further, such as when pointed at a table dir.
There was a problem hiding this comment.
Sure, I updated the comment to hint at both current cases for the input dirs: and (but without specifically mentioning MapReduceBackupMergeJob)
|
Also please run |
thomassngdata
force-pushed
the
HBASE-28483_backup_merge_fails_bulkloaded_hfiles
branch
from
a828ccf to
9714577
Compare
|
Issue with |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
What I was referring to about spotless was this error in the first build: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-general-check/output/patch-spotless.txt Spotless helps maintain our formatting guidelines. Where did you see it complaining about the hamcrest dependency? I see the formatting issues have been fixed, but I'm not sure we should change the pom.xml unless there was a reason |
|
I investigated and it does seem like a true duplicate. I don't think this was related, but it's ok. More importantly, the spotless formatting issues have been fixed. Going to merge this |
bbeaudreault
pushed a commit
that referenced
this pull request
Apr 6, 2024
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault
pushed a commit
that referenced
this pull request
Apr 6, 2024
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault
pushed a commit
that referenced
this pull request
Apr 6, 2024
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Apr 6, 2024
…apache#5795) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.