HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance #5797

charlesconnell · 2024-04-05T14:55:34Z

The zstd documentation recommends re-using context objects when possible, because their creation has some expense. They can be more cheaply reset than re-created. In this PR, create one Zstd(De)compressCtx for the lifetime of a Compressor or Decompressor object.

Apache-HBase · 2024-04-05T15:23:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	0m 14s	master passed
+1 💚	shadedjars	5m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	5m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 24s	hbase-compression-zstd in the patch failed.
		17m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c1e1abddcf14 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-compression_hbase-compression-zstd.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/testReport/
Max. process+thread count	168 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:26:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	5m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 59s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	5m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 26s	hbase-compression-zstd in the patch failed.
		20m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 61ef5ab3d97a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-compression_hbase-compression-zstd.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/testReport/
Max. process+thread count	162 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:28:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 47s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	6m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	6m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 28s	hbase-compression-zstd in the patch failed.
		23m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 12ad0f696985 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-17.0.10+7
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-compression_hbase-compression-zstd.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/testReport/
Max. process+thread count	158 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:31:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 41s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	checkstyle	0m 10s	master passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	checkstyle	0m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 20s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 51s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		25m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b3c84d656c69 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:50:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	0m 14s	master passed
+1 💚	shadedjars	5m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	5m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 29s	hbase-compression-zstd in the patch failed.
		17m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 993966d02f74 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-compression_hbase-compression-zstd.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/testReport/
Max. process+thread count	168 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:53:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 57s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	5m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	5m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 34s	hbase-compression-zstd in the patch failed.
		20m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5035c679db10 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-compression_hbase-compression-zstd.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/testReport/
Max. process+thread count	152 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:56:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	6m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	6m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 41s	hbase-compression-zstd in the patch failed.
		23m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 01a20ca86362 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-17.0.10+7
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-compression_hbase-compression-zstd.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/testReport/
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T15:57:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	checkstyle	0m 8s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
+1 💚	checkstyle	0m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 59s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 51s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		25m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c60b2519d3b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T18:43:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 5s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	5m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	5m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 52s	hbase-compression-zstd in the patch passed.
		22m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 81cbf5ce3f5f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/testReport/
Max. process+thread count	594 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T18:45:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 29s	hbase-compression-zstd in the patch passed.
		24m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 69a320996f50 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/testReport/
Max. process+thread count	464 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T18:45:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	5m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 8s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	5m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 20s	hbase-compression-zstd in the patch passed.
		24m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 96ef34edf858 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/testReport/
Max. process+thread count	477 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-05T18:46:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 26s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	checkstyle	0m 9s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 56s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 50s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		25m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 19cd7173c7c1 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `aea7e7c`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell · 2024-04-08T15:37:01Z

...-compression-zstd/src/main/java/org/apache/hadoop/hbase/io/compress/zstd/ZstdCompressor.java

+    if (dict != null) {
+      ctx.loadDict(dict);
+    } else {
+      // loadDict((byte[]) accepts null to clear the dictionary


Did not know this was possible. Nice optimization.

apurtell · 2024-04-08T15:42:34Z

A note for any other reviewers. The difference between failed precommit runs and successful ones is d6843d3 .

Apache-HBase · 2024-04-08T17:45:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	0m 14s	master passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 17s	hbase-compression-zstd in the patch passed.
		25m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c6b7634adf63 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3340d8d`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/testReport/
Max. process+thread count	462 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-08T17:46:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 8s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	5m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 7s	hbase-compression-zstd in the patch passed.
		25m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a88e2daf959f 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3340d8d`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/testReport/
Max. process+thread count	473 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-08T17:47:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 54s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 47s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 54s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		26m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 28e0cccdc7c6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3340d8d`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-08T17:48:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 40s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	6m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	6m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 7s	hbase-compression-zstd in the patch passed.
		27m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5797
JIRA Issue	HBASE-28485
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 53ec2a3919e9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3340d8d`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/testReport/
Max. process+thread count	497 (vs. ulimit of 30000)
modules	C: hbase-compression/hbase-compression-zstd U: hbase-compression/hbase-compression-zstd
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5797/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk

Nice find.

…pache#5797) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…5797) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…pache#5797) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

charlesconnell force-pushed the HBASE-28485/zstd-compression-context branch 2 times, most recently from 0afdd33 to b066af9 Compare April 5, 2024 15:08

HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

93fb37f

charlesconnell force-pushed the HBASE-28485/zstd-compression-context branch from b066af9 to 93fb37f Compare April 5, 2024 15:13

The docs were lying a little

d6843d3

Apache9 requested a review from apurtell April 6, 2024 05:40

apurtell approved these changes Apr 8, 2024

View reviewed changes

context reset I forgot that is effectively a no-op, but just to be safe

4c703cc

ndimiduk approved these changes Apr 9, 2024

View reviewed changes

ndimiduk merged commit 1a089cd into apache:master Apr 9, 2024
1 check passed

charlesconnell deleted the HBASE-28485/zstd-compression-context branch June 17, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance #5797

HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance #5797

charlesconnell commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

apurtell Apr 8, 2024

apurtell commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

ndimiduk left a comment

HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance #5797

HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance #5797

Conversation

charlesconnell commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

Apache-HBase commented Apr 5, 2024

apurtell Apr 8, 2024

Choose a reason for hiding this comment

apurtell commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

Apache-HBase commented Apr 8, 2024

ndimiduk left a comment

Choose a reason for hiding this comment