Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28239 Auto create configured namespaces #5841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.NamespaceDescriptor;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.RegionInfoBuilder;
import org.apache.hadoop.hbase.client.TableDescriptor;
Expand Down Expand Up @@ -57,6 +58,8 @@ public class InitMetaProcedure extends AbstractStateMachineTableProcedure<InitMe

private static final Logger LOG = LoggerFactory.getLogger(InitMetaProcedure.class);

public static final String ADDITIONAL_NAMESPACES = "hbase.master.additional.namespaces";

private CountDownLatch latch = new CountDownLatch(1);

private RetryCounter retryCounter;
Expand Down Expand Up @@ -119,6 +122,19 @@ protected Flow executeFromState(MasterProcedureEnv env, InitMetaState state)
// namespaces when starting.
insertNamespaceToMeta(env.getMasterServices().getConnection(), DEFAULT_NAMESPACE);
insertNamespaceToMeta(env.getMasterServices().getConnection(), SYSTEM_NAMESPACE);
// create the additional namespaces based on the configuration value
String[] customNamespaces =
env.getMasterConfiguration().getStrings(ADDITIONAL_NAMESPACES);
if (null != customNamespaces && customNamespaces.length > 0) {
Arrays.stream(customNamespaces).forEach(ns -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just follow the regular way to create these namespaces?

We have to insert system namespace here because meta table is in this namespace, so there is a cyclic dependency...

For other namespaces, I suggest to create them with your own operational scripts or some management systems, from outside the cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improvement provides a config option for operators to create the additional namespaces during the HBase startup. This would eliminate the need to wrap createTable calls in checkAndCreateNamespace or provide separate cluster bootstrap functionality to guarantee that the namespace is created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the code can only take effect when initializing the cluster, i.e, on the first startup of this HBase cluster... If later you changed the configuration and restart the hbase cluster, it will not take effect.

I think this will confuse our users...

try {
insertNamespaceToMeta(env.getMasterServices().getConnection(),
NamespaceDescriptor.create(ns).build());
} catch (IOException e) {
throw new RuntimeException(e);
}
});
}

return Flow.NO_MORE_STATE;
default:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hadoop.hbase;

import static org.apache.hadoop.hbase.master.procedure.InitMetaProcedure.ADDITIONAL_NAMESPACES;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

import java.io.IOException;
import java.util.Arrays;
import java.util.List;
import org.apache.hadoop.hbase.client.Admin;
import org.apache.hadoop.hbase.master.HMaster;
import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.testclassification.MiscTests;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.rules.TestName;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Category({ MiscTests.class, MediumTests.class })
public class TestAdditionalNameSpaceCreation {

@ClassRule
public static final HBaseClassTestRule CLASS_RULE =
HBaseClassTestRule.forClass(TestAdditionalNameSpaceCreation.class);

private static final Logger LOG = LoggerFactory.getLogger(TestAdditionalNameSpaceCreation.class);
private static HMaster master;
protected final static int NUM_SLAVES_BASE = 4;
private static HBaseTestingUtil TEST_UTIL;
protected static Admin admin;
protected static HBaseClusterInterface cluster;

@Rule
public TestName name = new TestName();

@BeforeClass
public static void setUp() throws Exception {
TEST_UTIL = new HBaseTestingUtil();
TEST_UTIL.getConfiguration().setStrings(ADDITIONAL_NAMESPACES, "ns1", "ns2");
TEST_UTIL.startMiniCluster(NUM_SLAVES_BASE);
admin = TEST_UTIL.getAdmin();
cluster = TEST_UTIL.getHBaseCluster();
master = ((SingleProcessHBaseCluster) cluster).getMaster();
LOG.info("Done initializing cluster");
}

@AfterClass
public static void tearDown() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}

@Test
public void testCustomNameSpaceCreationDuringStartup() throws IOException {
List<String> namespaces = Arrays.asList(admin.listNamespaces());
assertEquals(4, namespaces.size());
assertTrue(namespaces.contains("ns1"));
assertTrue(namespaces.contains("ns2"));
}
}