-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28239 Auto create configured namespaces #5841
Open
chandrasekhar-188k
wants to merge
1
commit into
apache:master
Choose a base branch
from
chandrasekhar-188k:br_HBASE-28239
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
hbase-server/src/test/java/org/apache/hadoop/hbase/TestAdditionalNameSpaceCreation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.hadoop.hbase; | ||
|
||
import static org.apache.hadoop.hbase.master.procedure.InitMetaProcedure.ADDITIONAL_NAMESPACES; | ||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertTrue; | ||
|
||
import java.io.IOException; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import org.apache.hadoop.hbase.client.Admin; | ||
import org.apache.hadoop.hbase.master.HMaster; | ||
import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
import org.apache.hadoop.hbase.testclassification.MiscTests; | ||
import org.junit.AfterClass; | ||
import org.junit.BeforeClass; | ||
import org.junit.ClassRule; | ||
import org.junit.Rule; | ||
import org.junit.Test; | ||
import org.junit.experimental.categories.Category; | ||
import org.junit.rules.TestName; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
@Category({ MiscTests.class, MediumTests.class }) | ||
public class TestAdditionalNameSpaceCreation { | ||
|
||
@ClassRule | ||
public static final HBaseClassTestRule CLASS_RULE = | ||
HBaseClassTestRule.forClass(TestAdditionalNameSpaceCreation.class); | ||
|
||
private static final Logger LOG = LoggerFactory.getLogger(TestAdditionalNameSpaceCreation.class); | ||
private static HMaster master; | ||
protected final static int NUM_SLAVES_BASE = 4; | ||
private static HBaseTestingUtil TEST_UTIL; | ||
protected static Admin admin; | ||
protected static HBaseClusterInterface cluster; | ||
|
||
@Rule | ||
public TestName name = new TestName(); | ||
|
||
@BeforeClass | ||
public static void setUp() throws Exception { | ||
TEST_UTIL = new HBaseTestingUtil(); | ||
TEST_UTIL.getConfiguration().setStrings(ADDITIONAL_NAMESPACES, "ns1", "ns2"); | ||
TEST_UTIL.startMiniCluster(NUM_SLAVES_BASE); | ||
admin = TEST_UTIL.getAdmin(); | ||
cluster = TEST_UTIL.getHBaseCluster(); | ||
master = ((SingleProcessHBaseCluster) cluster).getMaster(); | ||
LOG.info("Done initializing cluster"); | ||
} | ||
|
||
@AfterClass | ||
public static void tearDown() throws Exception { | ||
TEST_UTIL.shutdownMiniCluster(); | ||
} | ||
|
||
@Test | ||
public void testCustomNameSpaceCreationDuringStartup() throws IOException { | ||
List<String> namespaces = Arrays.asList(admin.listNamespaces()); | ||
assertEquals(4, namespaces.size()); | ||
assertTrue(namespaces.contains("ns1")); | ||
assertTrue(namespaces.contains("ns2")); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just follow the regular way to create these namespaces?
We have to insert system namespace here because meta table is in this namespace, so there is a cyclic dependency...
For other namespaces, I suggest to create them with your own operational scripts or some management systems, from outside the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improvement provides a config option for operators to create the additional namespaces during the HBase startup. This would eliminate the need to wrap createTable calls in checkAndCreateNamespace or provide separate cluster bootstrap functionality to guarantee that the namespace is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the code can only take effect when initializing the cluster, i.e, on the first startup of this HBase cluster... If later you changed the configuration and restart the hbase cluster, it will not take effect.
I think this will confuse our users...