HBASE-28539 Merge of incremental backups fails if backups are on a separate FileSystem #5867

bcolyn-ngdata · 2024-05-02T14:16:24Z

HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself.

anmolnar

lgtm. Please run mvn spotless:apply to fix styling problems.

bcolyn-ngdata · 2024-05-06T15:05:56Z

@anmolnar applied as requested

rmdmattingly

I had one minor suggestion, but this also looks good to me

rmdmattingly · 2024-05-07T16:46:05Z

hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java

+    File tempDir = new File(FileUtils.getTempDirectory(), UUID.randomUUID().toString());
+    tempDir.deleteOnExit();
+    BACKUP_ROOT_DIR = tempDir.toURI().toString();
+    System.out.println(BACKUP_ROOT_DIR);


It's not totally unheard of to print logs like this, especially in our test files, but maybe we should just use the logger?

@rmdmattingly I've removed the offending debug statement

ndimiduk

Core change seems good to me. I have some test reliability requests.

ndimiduk · 2024-05-21T13:18:58Z

hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java

@@ -124,4 +128,43 @@ public void TestIncBackupMergeRestore() throws Exception {
    admin.close();
    conn.close();
  }
+
+  @Test
+  public void TestIncBackupMergeRestoreSeparateFs() throws Exception {


Huh, strange. We don't usually use C# casing in Java code.

I was following the method above, but now changed it to typical Java standard.

ndimiduk · 2024-05-22T09:08:40Z

hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java

+
+    // prepare BACKUP_ROOT_DIR on a different filesystem from HBase
+    File tempDir = new File(FileUtils.getTempDirectory(), UUID.randomUUID().toString());
+    tempDir.deleteOnExit();


Over the years, we've found that deleteOnExit is unreliable for cleaning up unit tests. Better to allocate a path under the maven target directory instead. I believe that we have utility methods to accomplish this as part of HBaseTestingUtility.

ndimiduk · 2024-05-22T09:09:32Z

hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java

+    tempDir.deleteOnExit();
+    BACKUP_ROOT_DIR = tempDir.toURI().toString();
+
+    Connection conn = ConnectionFactory.createConnection(conf1);


please use try-with-resources to close the connection. Actually I'm surprised that we don't have a static analysis tool warning about this.

bcolyn-ngdata · 2024-05-31T16:04:23Z

@ndimiduk
Sorry this took a while, but your requested changes have been applied.

Apache-HBase · 2024-05-31T16:35:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	11m 34s	hbase-backup in the patch passed.
		29m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4752c0507d1b 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `abea484`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/testReport/
Max. process+thread count	3739 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-31T16:40:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 47s	master passed
+1 💚	compile	0m 36s	master passed
+1 💚	checkstyle	0m 20s	master passed
+1 💚	spotless	1m 10s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 31s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	checkstyle	0m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 7s	Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌	spotless	1m 1s	patch has 40 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		34m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 7d4a6c33d4ce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `abea484`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-31T16:43:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 14s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	7m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	7m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	12m 17s	hbase-backup in the patch passed.
		37m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e387ebbe8278 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `abea484`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/testReport/
Max. process+thread count	3676 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-31T16:43:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	7m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 34s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	7m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	11m 27s	hbase-backup in the patch passed.
		37m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c7aeb940635f 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `abea484`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/testReport/
Max. process+thread count	3150 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2024-06-06T12:18:23Z

Heya @bcolyn-ngdata can you please run mvn spotless:apply and push the resulting change, or give me permission to add contributions to this PR. Thanks.

…stem is not the same as the one underpinning HBase itself.

bcolyn-ngdata · 2024-06-06T12:40:14Z

Hi @ndimiduk

I've run the spotless:apply (sorry, should have done that already) and amended the PR

Apache-HBase · 2024-06-06T13:15:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 18s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 12s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	checkstyle	0m 11s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 5s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 44s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 39s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		24m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ffa40c454718 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c865570`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-06T13:21:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 47s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	5m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	5m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 8s	hbase-backup in the patch passed.
		30m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d11dc9d318ee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c865570`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/testReport/
Max. process+thread count	3857 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-06T13:24:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	5m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	12m 1s	hbase-backup in the patch passed.
		33m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5433906630a4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c865570`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/testReport/
Max. process+thread count	3091 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-06T13:27:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	6m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	6m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	12m 28s	hbase-backup in the patch passed.
		36m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5867
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1f1ddf89e9ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c865570`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/testReport/
Max. process+thread count	3725 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5867/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…parate FileSystem (apache#5867) When the backups are stored on a location that is not the DistributedFilesystem underpinning HBase itself merging of incremental backups fails. Detected with backups stored on S3A, but can be reproduced with any other (like LocalFilesystem). Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Andor Molnár <andor@apache.org>

…parate FileSystem (#5867) When the backups are stored on a location that is not the DistributedFilesystem underpinning HBase itself merging of incremental backups fails. Detected with backups stored on S3A, but can be reproduced with any other (like LocalFilesystem). Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Andor Molnár <andor@apache.org>

This comment has been minimized.

Sign in to view

anmolnar approved these changes May 3, 2024

View reviewed changes

bcolyn-ngdata force-pushed the HBASE-28539_merge_backups_alt_filesystem branch from cc47335 to 0b6738e Compare May 6, 2024 15:05

This comment has been minimized.

Sign in to view

rmdmattingly reviewed May 7, 2024

View reviewed changes

bcolyn-ngdata force-pushed the HBASE-28539_merge_backups_alt_filesystem branch from 0b6738e to 711535b Compare May 13, 2024 15:17

This comment has been minimized.

Sign in to view

ndimiduk requested changes May 22, 2024

View reviewed changes

ndimiduk changed the title ~~HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself.~~ HBASE-28539 Merge of incremental backups fails if backups are on a separate FileSystem May 22, 2024

bcolyn-ngdata force-pushed the HBASE-28539_merge_backups_alt_filesystem branch from 711535b to e07a599 Compare May 31, 2024 16:04

ndimiduk approved these changes Jun 6, 2024

View reviewed changes

HBASE-28539 Fix merging of incremental backups when the backup filesy…

1d18900

…stem is not the same as the one underpinning HBase itself.

bcolyn-ngdata force-pushed the HBASE-28539_merge_backups_alt_filesystem branch from e07a599 to 1d18900 Compare June 6, 2024 12:37

ndimiduk approved these changes Jun 6, 2024

View reviewed changes

ndimiduk merged commit 00b1bba into apache:master Jun 6, 2024
1 check passed

HBASE-28539 Merge of incremental backups fails if backups are on a separate FileSystem #5867

HBASE-28539 Merge of incremental backups fails if backups are on a separate FileSystem #5867

Conversation

bcolyn-ngdata commented May 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

anmolnar left a comment

Choose a reason for hiding this comment

bcolyn-ngdata commented May 6, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rmdmattingly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcolyn-ngdata commented May 31, 2024

Apache-HBase commented May 31, 2024

Apache-HBase commented May 31, 2024

Apache-HBase commented May 31, 2024

Apache-HBase commented May 31, 2024

ndimiduk commented Jun 6, 2024

bcolyn-ngdata commented Jun 6, 2024

Apache-HBase commented Jun 6, 2024

Apache-HBase commented Jun 6, 2024

Apache-HBase commented Jun 6, 2024

Apache-HBase commented Jun 6, 2024