HBASE-28502 Cleanup old backup manifest logic #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
rmdmattingly
approved these changes
May 7, 2024
ndimiduk
approved these changes
May 10, 2024
There was a problem hiding this comment.
Looks good to me. It would be good to solicit comments from whomever made the change that deprecated the old manifest logic in the first place. @DieterDP-ng do you know whom that might be? Maybe check the relevant commit logs. Please @-mention them on this ticket.
| return new Path(getLogBackupDir(backupRootDir, backupId)); | ||
| } | ||
|
|
||
| // TODO we do not keep WAL files anymore |
There was a problem hiding this comment.
Removal of this TODO is accurate?
There was a problem hiding this comment.
My interpretation of this TODO (introduced in HBASE-14135), is that it was already implemented in that same commit. If that weren't the case, the TODO message is too vague for me to understand what needs to be done, rendering it useless anyway.
|
Looks like both modified test methods were executed and passed. |
I think this was done in HBASE-14135, committed by @joshelser, with @VladRodionov mentioned. |
|
👋🏼 sorry, I don't recall exactly what was being put into the incremental backups anymore. I remember holding on to all of the WAL files quickly got out of control and we talked about consolidating multiple incremental backups (lists of WALs) into hfiles, but I don't remember exactly what was implemented. |
|
Merged to master. I'll start backporting and holler if I have any issues. Thanks for the contribution @DieterDP-ng and for the review @rmdmattingly ! |
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
May 15, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
May 15, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
May 15, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
that referenced
this pull request
May 16, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
that referenced
this pull request
May 16, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
that referenced
this pull request
May 16, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
to HubSpot/hbase
that referenced
this pull request
May 16, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
May 16, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
rmdmattingly
pushed a commit
to HubSpot/hbase
that referenced
this pull request
May 17, 2024
…he#5871) In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
rmdmattingly
pushed a commit
to HubSpot/hbase
that referenced
this pull request
May 17, 2024
…he#5871) In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
rmdmattingly
pushed a commit
to HubSpot/hbase
that referenced
this pull request
May 17, 2024
…he#5871) (#94) In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: DieterDP <90392398+DieterDP-ng@users.noreply.github.com>
rmdmattingly
pushed a commit
to HubSpot/hbase
that referenced
this pull request
May 17, 2024
…he#5871) (#95) In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: DieterDP <90392398+DieterDP-ng@users.noreply.github.com>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
May 21, 2024
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
rmdmattingly
pushed a commit
to HubSpot/hbase
that referenced
this pull request
May 21, 2024
…he#5871) (#94) In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup. Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: DieterDP <90392398+DieterDP-ng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete issue with the old code was that the manifest for full backups did not correctly list the tables included in the backup.