HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… #5903

Apache9 · 2024-05-15T15:44:14Z

… when closing unused region replicas

Apache-HBase · 2024-05-15T16:27:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s	master passed
+1 💚	compile	3m 21s	master passed
+1 💚	checkstyle	0m 46s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	3m 19s	the patch passed
+1 💚	cc	3m 19s	the patch passed
+1 💚	javac	3m 19s	the patch passed
+1 💚	checkstyle	0m 45s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	4m 52s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	hbaseprotoc	1m 7s	the patch passed
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	3m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		36m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	dupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux c38633fc4845 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d1fc87e`
Default Java	Eclipse Adoptium-11.0.17+8
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-15T20:04:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
-1 ❌	mvninstall	0m 20s	root in master failed.
-1 ❌	compile	0m 7s	hbase-protocol-shaded in master failed.
-1 ❌	compile	0m 22s	hbase-server in master failed.
-1 ❌	shadedjars	4m 55s	branch has 11 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 6s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	5m 40s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	hbase-server generated 22 new + 0 unchanged - 0 fixed = 22 total (was 0)
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	232m 23s	hbase-server in the patch passed.
		253m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 30e4559cdb01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d1fc87e`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-protocol-shaded.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/branch-shadedjars.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/testReport/
Max. process+thread count	5092 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-15T20:05:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 1s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	shadedjars	5m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 36s	hbase-protocol-shaded in the patch passed.
-1 ❌	unit	227m 19s	hbase-server in the patch failed.
		254m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 778e32ce6d25 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d1fc87e`
Default Java	Eclipse Adoptium-17.0.10+7
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/testReport/
Max. process+thread count	5019 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-15T20:35:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	1m 28s	master passed
+1 💚	shadedjars	5m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	1m 57s	the patch passed
+1 💚	javac	1m 57s	the patch passed
+1 💚	shadedjars	7m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 40s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	255m 40s	hbase-server in the patch passed.
		284m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux f66ca81d5244 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d1fc87e`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/testReport/
Max. process+thread count	4693 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… when closing unused region replicas

Apache-HBase · 2024-05-16T15:56:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	3m 19s	master passed
+1 💚	checkstyle	0m 44s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	3m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	3m 18s	the patch passed
+1 💚	cc	3m 18s	the patch passed
+1 💚	javac	3m 18s	the patch passed
+1 💚	checkstyle	0m 46s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	4m 54s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	hbaseprotoc	1m 4s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	3m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		36m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	dupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux dc545c7b00bc 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716adf5`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-16T19:45:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	1m 30s	master passed
+1 💚	shadedjars	5m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	1m 31s	the patch passed
+1 💚	javac	1m 31s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	237m 34s	hbase-server in the patch passed.
		264m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux a923c0ee21f3 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716adf5`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/testReport/
Max. process+thread count	4974 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-16T20:13:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 35s	master passed
+1 💚	compile	1m 5s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	5m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-protocol-shaded in the patch passed.
-1 ❌	unit	267m 4s	hbase-server in the patch failed.
		292m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 13e28e65616e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716adf5`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/testReport/
Max. process+thread count	4637 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-16T21:01:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	1m 30s	master passed
+1 💚	shadedjars	5m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 36s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	313m 56s	hbase-server in the patch passed.
		341m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5903
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 13aff7585ffa 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716adf5`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/testReport/
Max. process+thread count	4838 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5903/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

I like this idea overall, just skimmed so far. Let me also add @apurtell, I will also take a detailed look but I am out for a few days.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java

...c/main/java/org/apache/hadoop/hbase/master/procedure/CloseExcessRegionReplicasProcedure.java

Apache9 · 2024-05-28T13:00:13Z

Any other concerns here? @virajjasani

Let's get this in, and then focus on how to deal with CloseTableProcedure?

Thanks.

… when closing unused region replicas (#5903) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit c4a7606)

Apache9 self-assigned this May 15, 2024

Apache9 added 2 commits May 16, 2024 23:16

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node…

a4c2140

… when closing unused region replicas

add test

d6298ee

Apache9 force-pushed the HBASE-28582 branch from 80c1f56 to d6298ee Compare May 16, 2024 15:17

Apache9 requested a review from virajjasani May 17, 2024 14:32

virajjasani reviewed May 17, 2024

View reviewed changes

virajjasani requested a review from apurtell May 17, 2024 15:37

virajjasani reviewed May 17, 2024

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Show resolved Hide resolved

Umeshkumar9414 reviewed May 22, 2024

View reviewed changes

...c/main/java/org/apache/hadoop/hbase/master/procedure/CloseExcessRegionReplicasProcedure.java Show resolved Hide resolved

virajjasani approved these changes May 28, 2024

View reviewed changes

Apache9 merged commit c4a7606 into apache:master May 29, 2024
1 check failed

Apache9 added a commit that referenced this pull request May 29, 2024

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node…

2332a30

… when closing unused region replicas (#5903) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit c4a7606)

Apache9 added a commit that referenced this pull request May 29, 2024

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node…

e461c3b

… when closing unused region replicas (#5903) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit c4a7606)

Apache9 added a commit that referenced this pull request May 29, 2024

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node…

f628ebb

… when closing unused region replicas (#5903) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit c4a7606)

Apache9 added a commit that referenced this pull request May 29, 2024

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node…

f9af303

… when closing unused region replicas (#5903) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit c4a7606)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… #5903

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… #5903

Apache9 commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 16, 2024

Apache-HBase commented May 16, 2024

Apache-HBase commented May 16, 2024

Apache-HBase commented May 16, 2024

virajjasani left a comment •

edited

Loading

Apache9 commented May 28, 2024

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… #5903

HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… #5903

Conversation

Apache9 commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 15, 2024

Apache-HBase commented May 16, 2024

Apache-HBase commented May 16, 2024

Apache-HBase commented May 16, 2024

Apache-HBase commented May 16, 2024

virajjasani left a comment • edited Loading

Choose a reason for hiding this comment

Apache9 commented May 28, 2024

virajjasani left a comment •

edited

Loading