HBASE-28568 Incremental backup set does not correctly shrink (addendum) #5917

ndimiduk · 2024-05-17T15:07:12Z

Import the correct shaded Guava and run spotless:apply.

Apache-HBase · 2024-05-17T15:47:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 32s	master passed
+1 💚	compile	0m 34s	master passed
+1 💚	checkstyle	0m 13s	master passed
-1 ❌	spotless	0m 53s	branch has 21 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	checkstyle	0m 9s	hbase-backup: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 10s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	1m 0s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		26m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5917
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ea43b2c0d610 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b260199`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-17T15:51:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	12m 0s	hbase-backup in the patch passed.
		31m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5917
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 60d72f0ac7c9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b260199`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/testReport/
Max. process+thread count	3379 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-17T15:51:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 58s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	5m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	5m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	11m 39s	hbase-backup in the patch passed.
		31m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5917
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d12f8351a9e8 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b260199`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/testReport/
Max. process+thread count	3645 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-17T15:56:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 31s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	6m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	6m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
-1 ❌	unit	12m 6s	hbase-backup in the patch failed.
		35m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5917
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 57fc8628115f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b260199`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/testReport/
Max. process+thread count	3630 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5917/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…m) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

…m) (#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

…m) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

…ly shrink (addendum) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

…ly shrink (apache#5876) (#96) * HubSpot Backport: HBASE-28568 Incremental backup set does not correctly shrink (apache#5876) The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir). The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink. Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> * HubSpot Backport: HBASE-28568 Incremental backup set does not correctly shrink (addendum) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org> --------- Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Co-authored-by: DieterDP <90392398+DieterDP-ng@users.noreply.github.com>

…ly shrink (apache#5876) (#97) * HubSpot Backport: HBASE-28568 Incremental backup set does not correctly shrink (apache#5876) The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir). The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink. Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> * HubSpot Backport: HBASE-28568 Incremental backup set does not correctly shrink (addendum) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org> --------- Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Co-authored-by: DieterDP <90392398+DieterDP-ng@users.noreply.github.com>

HBASE-28568 Incremental backup set does not correctly shrink (addendum)

9472e77

Import the correct shaded Guava and run spotless:apply.

ndimiduk mentioned this pull request May 17, 2024

HBASE-28568 Fix incremental backup set shrinking #5876

Merged

Apache9 approved these changes May 17, 2024

View reviewed changes

ndimiduk merged commit b4c2712 into apache:master May 17, 2024
1 check failed

ndimiduk deleted the 28568-addendum branch May 17, 2024 16:31

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 17, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendu…

075d908

…m) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 17, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendu…

c4a8336

…m) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 17, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendu…

b8f6099

…m) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk added a commit that referenced this pull request May 18, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendu…

7f899f5

…m) (#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk added a commit that referenced this pull request May 18, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendu…

794f6b4

…m) (#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk added a commit that referenced this pull request May 18, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendu…

ba12a6b

…m) (#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28568 Incremental backup set does not correctly shrink (addendum) #5917

HBASE-28568 Incremental backup set does not correctly shrink (addendum) #5917

ndimiduk commented May 17, 2024

Apache-HBase commented May 17, 2024

Apache-HBase commented May 17, 2024

Apache-HBase commented May 17, 2024

Apache-HBase commented May 17, 2024

HBASE-28568 Incremental backup set does not correctly shrink (addendum) #5917

HBASE-28568 Incremental backup set does not correctly shrink (addendum) #5917

Conversation

ndimiduk commented May 17, 2024

Apache-HBase commented May 17, 2024

Apache-HBase commented May 17, 2024

Apache-HBase commented May 17, 2024

Apache-HBase commented May 17, 2024