Skip to content

HBASE-22982: region server suspend/resume and graceful rolling restart actions #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meszibalu merged 5 commits into from
Sep 26, 2019
Merged

HBASE-22982: region server suspend/resume and graceful rolling restart actions #592

meszibalu merged 5 commits into from
Sep 26, 2019

Conversation

@BukrosSzabolcs
Copy link
Contributor

@BukrosSzabolcs BukrosSzabolcs commented Sep 6, 2019

Add chaos monkey action for suspend/resume region servers
Add chaos monkey action for graceful rolling restart
Add these to relevant chaos monkeys

@BukrosSzabolcs
HBASE-22982
e66abf1 
Add chaos monkey action for suspend/resume region servers
Add chaos monkey action for graceful rolling restart
Add these to relevant chaos monkeys
@Apache-HBase
Copy link

Apache-HBase commented Sep 6, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 41s Docker mode activated.
_ Prechecks _
💚 dupname 0m 1s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 37s Maven dependency ordering for branch
💚 mvninstall 5m 39s master passed
💚 compile 1m 26s master passed
💚 checkstyle 1m 38s master passed
💚 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 50s master passed
💙 spotbugs 4m 15s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 4m 11s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 5m 27s the patch passed
💚 compile 1m 25s the patch passed
💚 javac 1m 25s the patch passed
💔 checkstyle 1m 25s hbase-server: The patch generated 4 new + 26 unchanged - 0 fixed = 30 total (was 26)
💔 checkstyle 0m 19s hbase-it: The patch generated 43 new + 74 unchanged - 1 fixed = 117 total (was 75)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 34s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 16m 2s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 49s the patch passed
💚 findbugs 4m 3s the patch passed
_ Other Tests _
💚 unit 167m 22s hbase-server in the patch passed.
💚 unit 1m 9s hbase-it in the patch passed.
💚 asflicense 1m 5s The patch does not generate ASF License warnings.
230m 5s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HBASE-22982
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5421f3daabfb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revision master / 51b6ce3
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/artifact/out/diff-checkstyle-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/artifact/out/diff-checkstyle-hbase-it.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/testReport/
Max. process+thread count 4455 (vs. ulimit of 10000)
modules C: hbase-server hbase-it U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@BukrosSzabolcs
HBASE-22982
f8b6b0f 
checkstyle fixes
@Apache-HBase
Copy link

Apache-HBase commented Sep 9, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 44s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 1s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 37s Maven dependency ordering for branch
💚 mvninstall 6m 14s master passed
💚 compile 1m 32s master passed
💚 checkstyle 1m 39s master passed
💚 shadedjars 4m 45s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 51s master passed
💙 spotbugs 4m 7s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 4m 4s master passed
_ Patch Compile Tests _
💙 mvndep 0m 16s Maven dependency ordering for patch
💚 mvninstall 4m 50s the patch passed
💚 compile 1m 23s the patch passed
💚 javac 1m 23s the patch passed
💚 checkstyle 1m 17s The patch passed checkstyle in hbase-server
💚 checkstyle 0m 17s hbase-it: The patch generated 0 new + 11 unchanged - 64 fixed = 11 total (was 75)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 41s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 16m 20s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 49s the patch passed
💚 findbugs 4m 1s the patch passed
_ Other Tests _
💔 unit 165m 6s hbase-server in the patch failed.
💚 unit 1m 6s hbase-it in the patch passed.
💚 asflicense 0m 58s The patch does not generate ASF License warnings.
228m 7s
Reason Tests
Failed junit tests hadoop.hbase.replication.regionserver.TestReplicator
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HBASE-22982
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8554dd261a27 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revision master / 7648855
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/testReport/
Max. process+thread count 4224 (vs. ulimit of 10000)
modules C: hbase-server hbase-it U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@BukrosSzabolcs
Copy link
Contributor Author

BukrosSzabolcs commented Sep 9, 2019

The failing test (org.apache.hadoop.hbase.replication.regionserver.TestReplicator) seems to be flaky. I have run the test a few times locally on the master branch and it seems to fail once in every 6-7 runs for me even without my changes.

@BukrosSzabolcs BukrosSzabolcs changed the title HBASE-22982 HBASE-22982: region server suspend/resume and graceful rolling restart actions Sep 9, 2019
meszibalu
meszibalu requested changes Sep 18, 2019
View reviewed changes
@BukrosSzabolcs
HBASE-22982
5cc76d1 
use parametrized logging in affected classes
other small fixes
@Apache-HBase
Copy link

Apache-HBase commented Sep 18, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 39s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 34s Maven dependency ordering for branch
💚 mvninstall 5m 18s master passed
💚 compile 1m 28s master passed
💚 checkstyle 1m 38s master passed
💚 shadedjars 4m 36s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 49s master passed
💙 spotbugs 4m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 4m 16s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 5m 8s the patch passed
💚 compile 1m 25s the patch passed
💚 javac 1m 25s the patch passed
💚 checkstyle 1m 16s The patch passed checkstyle in hbase-server
💚 checkstyle 0m 15s hbase-it: The patch generated 0 new + 11 unchanged - 64 fixed = 11 total (was 75)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 35s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 16m 32s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 53s the patch passed
💚 findbugs 4m 21s the patch passed
_ Other Tests _
💚 unit 162m 40s hbase-server in the patch passed.
💚 unit 1m 10s hbase-it in the patch passed.
💚 asflicense 1m 6s The patch does not generate ASF License warnings.
226m 11s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/3/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HBASE-22982
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6a18c5fb65b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revision master / ab076b0
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/3/testReport/
Max. process+thread count 4348 (vs. ulimit of 10000)
modules C: hbase-server hbase-it U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi
petersomogyi requested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left a couple of comments.

@BukrosSzabolcs
HBASE-22982
a86975a 
reverse formatting for otherwiseuntouched code
additional logging added
typos fixed
@Apache-HBase
Copy link

Apache-HBase commented Sep 25, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 37s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 38s Maven dependency ordering for branch
💚 mvninstall 5m 11s master passed
💚 compile 1m 30s master passed
💚 checkstyle 1m 39s master passed
💚 shadedjars 4m 37s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 51s master passed
💙 spotbugs 4m 14s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 4m 11s master passed
_ Patch Compile Tests _
💙 mvndep 0m 16s Maven dependency ordering for patch
💚 mvninstall 5m 1s the patch passed
💚 compile 1m 28s the patch passed
💚 javac 1m 28s the patch passed
💔 checkstyle 0m 19s hbase-it: The patch generated 1 new + 74 unchanged - 1 fixed = 75 total (was 75)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 35s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 15m 52s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 52s the patch passed
💚 findbugs 4m 10s the patch passed
_ Other Tests _
💚 unit 161m 3s hbase-server in the patch passed.
💚 unit 1m 9s hbase-it in the patch passed.
💚 asflicense 1m 5s The patch does not generate ASF License warnings.
223m 0s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HBASE-22982
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2a978432d40e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revision master / 52f5a85
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/artifact/out/diff-checkstyle-hbase-it.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/testReport/
Max. process+thread count 4449 (vs. ulimit of 10000)
modules C: hbase-server hbase-it U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@BukrosSzabolcs
HBASE-22982
6285cb1 
checkstlye fix
@meszibalu meszibalu merged commit f0dddd1 into apache:master Sep 26, 2019
asfgit pushed a commit that referenced this pull request Sep 26, 2019
@BukrosSzabolcs @meszibalu
HBASE-22982: region server suspend/resume and graceful rolling restar…
cd93675 
…t actions (#592)

* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@Apache-HBase
Copy link

Apache-HBase commented Sep 26, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 12s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 36s Maven dependency ordering for branch
💚 mvninstall 5m 57s master passed
💚 compile 1m 29s master passed
💚 checkstyle 1m 45s master passed
💚 shadedjars 5m 21s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 48s master passed
💙 spotbugs 4m 39s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 4m 36s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 5m 49s the patch passed
💚 compile 1m 28s the patch passed
💚 javac 1m 28s the patch passed
💚 checkstyle 1m 29s The patch passed checkstyle in hbase-server
💚 checkstyle 0m 17s hbase-it: The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 58s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 17m 25s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 48s the patch passed
💚 findbugs 4m 39s the patch passed
_ Other Tests _
💚 unit 229m 9s hbase-server in the patch passed.
💚 unit 1m 7s hbase-it in the patch passed.
💚 asflicense 0m 49s The patch does not generate ASF License warnings.
296m 58s
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/5/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HBASE-22982
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 314f014e1735 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revision master / ea24ea7
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/5/testReport/
Max. process+thread count 4901 (vs. ulimit of 10000)
modules C: hbase-server hbase-it U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

BukrosSzabolcs added a commit to BukrosSzabolcs/hbase that referenced this pull request Nov 13, 2019
@BukrosSzabolcs
HBASE-22982: region server suspend/resume and graceful rolling restar…
9aca065 
…t actions (apache#592)

* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@BukrosSzabolcs BukrosSzabolcs mentioned this pull request Nov 13, 2019
Closed
BukrosSzabolcs added a commit to BukrosSzabolcs/hbase that referenced this pull request Nov 13, 2019
@BukrosSzabolcs
HBASE-22982: region server suspend/resume and graceful rolling restar…
f36802e 
…t actions (apache#592)

* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@BukrosSzabolcs BukrosSzabolcs mentioned this pull request Nov 13, 2019
Merged
bharathv pushed a commit to bharathv/hbase that referenced this pull request Jun 22, 2020
@BukrosSzabolcs @bharathv
HBASE-22982: region server suspend/resume (apache#592)
b0766d2 
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys

branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit to bharathv/hbase that referenced this pull request Jun 22, 2020
@BukrosSzabolcs @bharathv
HBASE-22982: region server suspend/resume (apache#592)
b6da0b1 
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys

branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit to bharathv/hbase that referenced this pull request Jun 22, 2020
@BukrosSzabolcs @bharathv
HBASE-22982: region server suspend/resume (apache#592)
fbb2f58 
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys

branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit that referenced this pull request Jun 22, 2020
@BukrosSzabolcs @bharathv
HBASE-22982: region server suspend/resume (#592)
186373b 
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys

branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@BukrosSzabolcs
HBASE-22982: region server suspend/resume and graceful rolling restar…
adda37a 
…t actions (apache#592)

* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@wchevreuil wchevreuil mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyi petersomogyi petersomogyi requested changes

@meszibalu meszibalu meszibalu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BukrosSzabolcs @Apache-HBase @petersomogyi @meszibalu