Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28614 Introduce a field to display whether the snapshot is expired #5947

Merged
merged 1 commit into from
Jun 5, 2024
Merged

HBASE-28614 Introduce a field to display whether the snapshot is expired #5947

merged 1 commit into from
Jun 5, 2024

Conversation

guluo2016
Copy link
Contributor

Details see: HBASE-28614

After applying this commit.

On HBase UI:
image

image

image

On hbase shell:

hbase:027:0> list_snapshots
SNAPSHOT                                    TABLE + CREATION TIME + TTL(Sec)
 expired_snap01                             t01 (2024-05-26 14:18:16 +0800) 10 (Expired)
 snap01                                     t01 (2024-05-25 22:28:13 +0800) FOREVER
 snap02                                     t01 (2024-05-25 22:28:37 +0800) 100000
3 row(s)
Took 0.0209 seconds
=> ["expired_snap01", "snap01", "snap02"]

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s master passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 17s the patch passed
-0 ⚠️ rubocop 0m 4s The patch generated 7 new + 3 unchanged - 3 fixed = 10 total (was 6)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 57s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
11m 54s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5947
Optional Tests dupname asflicense javac spotless rubocop
uname Linux 8d35d2c7a453 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2130e54
Default Java Eclipse Adoptium-11.0.17+8
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/console
versions git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 6s master passed
+1 💚 javadoc 0m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 54s the patch passed
+1 💚 javadoc 0m 33s the patch passed
_ Other Tests _
+1 💚 unit 211m 12s hbase-server in the patch passed.
+1 💚 unit 6m 55s hbase-shell in the patch passed.
232m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5947
Optional Tests javac javadoc unit
uname Linux 273a2e53b582 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2130e54
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/testReport/
Max. process+thread count 4489 (vs. ulimit of 30000)
modules C: hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 19s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 14s master passed
+1 💚 javadoc 0m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 1s the patch passed
+1 💚 javadoc 0m 33s the patch passed
_ Other Tests _
+1 💚 unit 227m 39s hbase-server in the patch passed.
+1 💚 unit 6m 58s hbase-shell in the patch passed.
248m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5947
Optional Tests javac javadoc unit
uname Linux d68fda05682c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2130e54
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/testReport/
Max. process+thread count 5111 (vs. ulimit of 30000)
modules C: hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 54s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 33s master passed
+1 💚 javadoc 0m 37s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 27s the patch passed
+1 💚 javadoc 0m 35s the patch passed
_ Other Tests _
+1 💚 unit 237m 38s hbase-server in the patch passed.
+1 💚 unit 7m 8s hbase-shell in the patch passed.
260m 15s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5947
Optional Tests javac javadoc unit
uname Linux 2e7094bf62fe 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2130e54
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/testReport/
Max. process+thread count 4705 (vs. ulimit of 30000)
modules C: hbase-server hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5947/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

pankaj72981
pankaj72981 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@pankaj72981 pankaj72981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

virajjasani
virajjasani approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9 Apache9 merged commit 8afd93e into apache:master Jun 5, 2024
1 check passed
Apache9 pushed a commit that referenced this pull request Jun 5, 2024
@guluo2016 @Apache9
HBASE-28614 Introduce a field to display whether the snapshot is expi…
a48292b 
…red (#5947)

Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 8afd93e)
Apache9 pushed a commit that referenced this pull request Jun 5, 2024
@guluo2016 @Apache9
HBASE-28614 Introduce a field to display whether the snapshot is expi…
f9294a3 
…red (#5947)

Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 8afd93e)
Apache9 pushed a commit that referenced this pull request Jun 5, 2024
@guluo2016 @Apache9
HBASE-28614 Introduce a field to display whether the snapshot is expi…
5264181 
…red (#5947)

Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 8afd93e)
Apache9 pushed a commit that referenced this pull request Jun 5, 2024
@guluo2016 @Apache9
HBASE-28614 Introduce a field to display whether the snapshot is expi…
69c4696 
…red (#5947)

Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 8afd93e)
@guluo2016 guluo2016 deleted the hbase_HBASE-28614 branch June 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

@pankaj72981 pankaj72981 pankaj72981 approved these changes

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guluo2016 @Apache-HBase @Apache9 @pankaj72981 @virajjasani