HBASE-28666: In WALEntryStream, always use current WALTailingReader if one exists #5994

charlesconnell · 2024-06-15T13:02:23Z

There was one code path within a if (reader != null) {} block that did not return and end the method early, thus allowing a subsequent line to re-create the reader. This was not the intention of the author. This PR closes this loophole.

Apache-HBase · 2024-06-15T13:33:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 4s	master passed
+1 💚	compile	2m 39s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	2m 36s	the patch passed
+1 💚	javac	2m 36s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	4m 59s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		28m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5994
JIRA Issue	HBASE-28666
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b687261aed8a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0e8cfdb`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-15T17:03:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 1s	master passed
+1 💚	compile	0m 54s	master passed
+1 💚	shadedjars	5m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	5m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	214m 8s	hbase-server in the patch passed.
		238m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5994
JIRA Issue	HBASE-28666
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e976909d8b50 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0e8cfdb`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/testReport/
Max. process+thread count	4875 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-15T17:19:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 4s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	shadedjars	5m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	0m 50s	the patch passed
+1 💚	javac	0m 50s	the patch passed
+1 💚	shadedjars	5m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	229m 29s	hbase-server in the patch passed.
		253m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5994
JIRA Issue	HBASE-28666
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 002909017a61 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0e8cfdb`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/testReport/
Max. process+thread count	5143 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-15T18:19:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	8m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	7m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	280m 44s	hbase-server in the patch passed.
		313m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5994
JIRA Issue	HBASE-28666
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ec5269ed7699 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0e8cfdb`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/testReport/
Max. process+thread count	6054 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5994/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ets (#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit bd8ad45)

…ked sockets (#5994)" This reverts commit bd8ad45.

…ts (#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org>

…ked sockets (#5994)" This reverts commit 0b70d6c.

…ts (#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit bd8ad45)

…ked sockets (#5994)" This reverts commit 5db6e5e.

…ts (#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit bd8ad45)

…ked sockets (#5994)" This reverts commit 564887f.

…ts (#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit bd8ad45)

…ts (apache#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit bd8ad45)

…ds to leaked sockets (apache#5994) (#106) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit bd8ad45) Co-authored-by: Charles Connell <cconnell@hubspot.com>

In WALEntryStream, always use current WALTailingReader if one exists

ef11316

Apache9 approved these changes Jun 16, 2024

View reviewed changes

Apache9 merged commit bd8ad45 into apache:master Jun 16, 2024
1 check passed

Apache9 added a commit that referenced this pull request Jun 16, 2024

Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to lea…

9ef621d

…ked sockets (#5994)" This reverts commit bd8ad45.

Apache9 pushed a commit that referenced this pull request Jun 16, 2024

HBASE-28666 Dropping unclosed WALTailingReaders leads to leaked socke…

60c4611

…ts (#5994) In WALEntryStream, always use current WALTailingReader if one exists Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 added a commit that referenced this pull request Jun 16, 2024

Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to lea…

a33b8c2

…ked sockets (#5994)" This reverts commit 0b70d6c.

Apache9 added a commit that referenced this pull request Jun 16, 2024

Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to lea…

a4adde1

…ked sockets (#5994)" This reverts commit 5db6e5e.

Apache9 added a commit that referenced this pull request Jun 16, 2024

Revert "HBASE--28666 Dropping unclosed WALTailingReaders leads to lea…

0aa8e10

…ked sockets (#5994)" This reverts commit 564887f.

charlesconnell deleted the dont-recreate-wal-reader branch June 17, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28666: In WALEntryStream, always use current WALTailingReader if one exists #5994

HBASE-28666: In WALEntryStream, always use current WALTailingReader if one exists #5994

charlesconnell commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

HBASE-28666: In WALEntryStream, always use current WALTailingReader if one exists #5994

HBASE-28666: In WALEntryStream, always use current WALTailingReader if one exists #5994

Conversation

charlesconnell commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024

Apache-HBase commented Jun 15, 2024