HBASE-28656 Optimize the verifyCopyResult logic in ExportSnapshot #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Please check the failed UTs? |
|
@Apache9 Ok. Additionally, I will add a UT to cover the code. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@jojochuang @Apache9 Could you all take a look? Thanks. |
Apache9
approved these changes
Jun 20, 2024
|
Ping @jojochuang |
jojochuang
reviewed
Jun 20, 2024
| // or the algorithms of input and output are not equal, that means there is no comparison | ||
| // and return not compatible. else if matched, return compatible with the matched result. | ||
| if ( | ||
| !inputScheme.equals(outputScheme) || inChecksum == null || outChecksum == null |
There was a problem hiding this comment.
I would like to ask to drop the scheme name comparison.
I think it makes sense to check for algorithm name mismatch and to check for checksum nullity, but at file system level, we are starting to see more of them support compatible checksums.
E.g. HDFS and GCS supports COMPOSITE_CRC (Ozone supports it too)
https://cloud.google.com/architecture/hadoop/validating-data-transfers
I'd suggest to follow the file checksum comparision implemented in DistCP, return ChecksumComparison.INCOMPATIBLE if either of them is null. https://github.com/apache/hadoop/blob/9b8cc104fcafa604b03dd1565ff2283a6eaadbe4/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java#L591
There was a problem hiding this comment.
@jojochuang Ok, sir. and I already have a new commit, please review it.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
jojochuang
approved these changes
Jun 21, 2024
jojochuang
pushed a commit
that referenced
this pull request
Jun 21, 2024
) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> (cherry picked from commit dd694e4)
guluo2016
reviewed
Jul 4, 2024
| if ( | ||
| inChecksum == null || outChecksum == null | ||
| || !inChecksum.getAlgorithmName().equals(outChecksum.getAlgorithmName()) | ||
| ) { |
There was a problem hiding this comment.
@2005hithlj
I'm sorry for my late reply, as I just discovered this issue.
For LocalFileSystem, since it did not override the getFileChecksum method, LocalFileSystem.getFileChecksum always returns null.
Therefore, if we start a standalone hbase (eg: set hbase.rootdir file:///tmp/hbase), executing Exportsnapshot will fail because checksum failed in here.
There was a problem hiding this comment.
@guluo2016 Thank you for the review, for cases where LocalFileSystem.getFileChecksum returns null, you can specify --no-checksum-verify to ignore checksum verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-28656