HBASE-28676 Make pre commit build for 3.x to only run jdk 17 test #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Filed HBASE-28679 for the xml problem, and we can not move releaseTarget to 17 because there are tests failures on mockito, which may require code change. Plan to solve it in HBASE-28675. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The error for compile for the current master branch is expected, since we change to use jdk17 for compiling, we need to add some compile args for error prone. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
OK, good. Xml check can pass now. |
|
Merging this will cause the nightly build for master and branch-3 to fail since we still use jdk11 for general checks. Will start to work on HBASE-28678 ASAP after merging this PR. |
ndimiduk
approved these changes
Jun 26, 2024
| @@ -809,7 +809,7 @@ | |||
| <tar.name>${project.build.finalName}.tar.gz</tar.name> | |||
| <maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format> | |||
| <buildDate>${maven.build.timestamp}</buildDate> | |||
| <compileSource>1.8</compileSource> | |||
| @@ -809,7 +809,7 @@ | |||
| <tar.name>${project.build.finalName}.tar.gz</tar.name> | |||
| <maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format> | |||
| <buildDate>${maven.build.timestamp}</buildDate> | |||
| <compileSource>1.8</compileSource> | |||
| <compileSource>17</compileSource> | |||
| <releaseTarget>8</releaseTarget> | |||
There was a problem hiding this comment.
What does it mean to have compile target at 17 but release target at 8? Can javac emit bytecode for 17 features for an 8 VM?
We are dropping JDK8 runtime support, so I think we can move the release target up as well.
There was a problem hiding this comment.
ReleaseTarget 17 will break mockito, need to dig more...
@ndimiduk See here, I tried to jump to 17 too for releaseTarget at first, but it breaks mockito, so I plan to address it in HBASE-28675 since it may require java code changes. |
Apache9
added a commit
that referenced
this pull request
Jun 26, 2024
) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 80516d7)
|
Makes sense. Thanks @Apache9 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.