-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28679 Upgrade yetus to a newer version #6012
Conversation
For pre commit, see For Nightly build, see https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-28679/3/ |
(!) A patch to the testing environment has been detected. |
3 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
// output from surefire; sadly the archive function in yetus only works on file names. | ||
ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump' | ||
// These tests currently have known failures. Once they burn down to 0, remove from here so that new problems will cause a failure. | ||
TESTS_FILTER = 'cc,checkstyle,javac,javadoc,pylint,shellcheck,whitespace,perlcritic,ruby-lint,rubocop,mvnsite' | ||
TESTS_FILTER = 'checkstyle,javac,javadoc,pylint,shellcheck,shelldocs,blanks,perlcritic,ruby-lint,rubocop' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have C code in the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have some c code in hbase-example...
@@ -102,11 +104,11 @@ pipeline { | |||
checkout scm | |||
} | |||
dir("${YETUSDIR}") { | |||
checkout([ | |||
$class : 'GitSCM', | |||
branches : [[name: "${YETUS_VERSION}"]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, this previous behavior was so that we could test with upstream yetus feature branch if need be. Maybe unrealistic...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a special option for nightly job, for using the newest yetus code.
I think later we could introduce the same logic for pre commit.
allOf { | ||
// this will return true if the pipeline is building a change request, such as a GitHub pull request. | ||
changeRequest() | ||
expression { env.CHANGE_TARGET in ['master', 'branch-3'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be when in [master, branch-3, branch-2]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change this part later in HBASE-28678. We still have some problem for jdk17 builds, for example, we do not unstash the result later so on the final jira report we missed the jdk 17 line...
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 17ce7c3)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 17ce7c3)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 17ce7c3)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 17ce7c3)
No description provided.