Commits on Jun 21, 2024

1. HBASE-28680 BackupLogCleaner causes HMaster WALs to pile up indefinit… …

   …ely (apache#6006)
   
   We have been trying to setup daily incremental backups for hundreds of clusters at my day
   job. Recently we discovered that old WALs were piling up across many clusters inline with when we
   began running incremental backups.
   
   This led to the realization that the BackupLogCleaner will always skip archived HMaster WALs. This
   is a problem because, if a cleaner is skipping a given file, then the CleanerChore will never
   delete it.
   
   This seems like a misunderstanding of what it means to "skip" a WAL in a BaseLogCleanerDelegate,
   and, instead, we should always return these HMaster WALs as deletable from the perspective of the
   BackupLogCleaner. We could subject them to the same scrutiny as RegionServer WALs: are they older
   than the most recent successful backup? But, if I understand correctly, HMaster WALs do not
   contain any data relevant to table backups, so that would be unnecessary.
   
   Co-authored-by: Ray Mattingly <rmattingly@hubspot.com>
   Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

   

   2 people authored and ndimiduk committed Jun 21, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d4ecc08
   • Browse repository at this point

   Copy the full SHA

   d4ecc08 View commit details

   Browse the repository at this point in the history