-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28688 Correct the usage for blanks ignore options in yetus #6026
Conversation
Tested with HBASE-28688 branch, there is an extra commit for only running general checks on the HBASE-28688 branch in the main repo so I created a new branch to open the PR we want to merge. This is the nightly result, you can see that the blanks warnings are much less now This is the pre commit check, you can see that I manually added a line which ends with spaces but we just ignored it, which means the ignore file has taken effect. Will try another round as I added some more entries in the ignore files, let's see if we can make the result more clear. But anyway, we can confirm that the blanks ignore file finally works. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Guanghao Zhang <zghao@apache.org> (cherry picked from commit d1015a6)
Signed-off-by: Guanghao Zhang <zghao@apache.org> (cherry picked from commit d1015a6)
Signed-off-by: Guanghao Zhang <zghao@apache.org> (cherry picked from commit d1015a6)
Signed-off-by: Guanghao Zhang <zghao@apache.org> (cherry picked from commit d1015a6)
No description provided.