-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28712 Add JDK17 in the support matrix in our ref guide #6051
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@bbeaudreault PTAL. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this renders appropriately then lgtm
|icon:times-circle[role="red"] | ||
|icon:times-circle[role="red"] | ||
|HBase 2.6 | ||
2+|icon:times-circle[role="red"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these leading 2+ here and below intentional? I'm not super familiar with the syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2 means merge the two columns.
I found the rendered output and it looks good. I wonder if we should mark 2.5 as green though. We've been running it in prod for quite a while. The only issue we saw was HBASE-28206, which is fixed in the latest 2.5 release |
@apurtell What do you think? Thanks. |
We ran jdk17 in prod with a base version of 2.5.2 (with lots of backports, almost 2.6) for about a year. We've now been running jdk21 in prod for almost 9 months without any new issue. We've also been using the generational g1gc in java21 for some clusters. I wonder if it makes sense to at least mark java21 as preliminary support. |
For me I think at least we should have a pre commit and nightly task for that JDK version before we claim that we have support it... |
No description provided.