Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28712 Add JDK17 in the support matrix in our ref guide #6051

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jul 8, 2024

No description provided.

@Apache9 Apache9 self-assigned this Jul 8, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 17s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 11s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6051
Optional Tests
uname Linux 0eecf2fa568c 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 40c6ae8
Max. process+thread count 42 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 4s master passed
+0 🆗 refguide 2m 29s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 50s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+0 🆗 refguide 2m 13s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
13m 40s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6051
Optional Tests dupname asflicense codespell detsecrets refguide spotless
uname Linux 0cd81a9bbdf9 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 40c6ae8
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6051/1/yetus-general-check/output/branch-site/book.html
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6051/1/yetus-general-check/output/patch-site/book.html
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 16s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 8s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6051
Optional Tests
uname Linux 40653c8660d4 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 50a4c21
Max. process+thread count 35 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 0s master passed
+0 🆗 refguide 2m 31s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 52s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+0 🆗 refguide 2m 14s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
14m 15s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6051
Optional Tests dupname asflicense codespell detsecrets refguide spotless
uname Linux 2dfcbfe7f511 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 50a4c21
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6051/2/yetus-general-check/output/branch-site/book.html
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6051/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6051/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 requested a review from bbeaudreault July 9, 2024 08:11
@Apache9
Copy link
Contributor Author

Apache9 commented Jul 9, 2024

@bbeaudreault PTAL.

Thanks.

Copy link
Contributor

@bbeaudreault bbeaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this renders appropriately then lgtm

|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
|HBase 2.6
2+|icon:times-circle[role="red"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these leading 2+ here and below intentional? I'm not super familiar with the syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2 means merge the two columns.

@bbeaudreault
Copy link
Contributor

I found the rendered output and it looks good. I wonder if we should mark 2.5 as green though. We've been running it in prod for quite a while. The only issue we saw was HBASE-28206, which is fixed in the latest 2.5 release

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 9, 2024

I found the rendered output and it looks good. I wonder if we should mark 2.5 as green though. We've been running it in prod for quite a while. The only issue we saw was HBASE-28206, which is fixed in the latest 2.5 release

@apurtell What do you think? Thanks.

@bbeaudreault
Copy link
Contributor

We ran jdk17 in prod with a base version of 2.5.2 (with lots of backports, almost 2.6) for about a year. We've now been running jdk21 in prod for almost 9 months without any new issue. We've also been using the generational g1gc in java21 for some clusters. I wonder if it makes sense to at least mark java21 as preliminary support.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 9, 2024

We ran jdk17 in prod with a base version of 2.5.2 (with lots of backports, almost 2.6) for about a year. We've now been running jdk21 in prod for almost 9 months without any new issue. We've also been using the generational g1gc in java21 for some clusters. I wonder if it makes sense to at least mark java21 as preliminary support.

For me I think at least we should have a pre commit and nightly task for that JDK version before we claim that we have support it...

@Apache9 Apache9 merged commit 6f3b8c8 into apache:master Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants