HBASE-28717 Support FuzzyRowFilter in REST interface #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
payert
approved these changes
Jul 9, 2024
| @@ -458,6 +520,12 @@ public FilterModel(Filter filter) { | |||
| this.filters = new ArrayList<>(); | |||
| this.filters.add(new FilterModel(((WhileMatchFilter) filter).getFilter())); | |||
| break; | |||
| case FuzzyRowFilter: | |||
| this.fuzzyKeys = new ArrayList<>(); | |||
There was a problem hiding this comment.
nit: it might be worth to extract the size of the fuzzyKeys and initialize the array list with that as you do in other cases.
wchevreuil
reviewed
Jul 9, 2024
| * Returns the Fuzzy keys in the format expected by the constructor. | ||
| * @return the Fuzzy keys in the format expected by the constructor | ||
| */ | ||
| public List<Pair<byte[], byte[]>> getFuzzyKeys() { |
There was a problem hiding this comment.
nit: can we rename this method to resetIfPreprocessed?
There was a problem hiding this comment.
That would be misleading.
We are not changing the state of the object, we only revert the preprocessing on the copies that we return.
From the point of view of the caller, he gets back the same keys+masks that the filter was initialized with, the preprocessing and reverting that is an implementation detail.
There was a problem hiding this comment.
(actually, the don't care bytes are zeroed out, but we don't care about that)
| */ | ||
| public List<Pair<byte[], byte[]>> getFuzzyKeys() { | ||
| List<Pair<byte[], byte[]>> returnList = new ArrayList<>(fuzzyKeysData.size()); | ||
| for (Pair<byte[], byte[]> fuzzyKey : fuzzyKeysData) { |
There was a problem hiding this comment.
Should we have a boolean flagging when masks have been preprocessed, so that we could avoid these loops when it hasn't?
There was a problem hiding this comment.
It doesn't really matter, becase this method is called only once when we serialize the filter on the client side for a REST call, so it is not in the hot path.
I can add the same checks that the preprocessMask() has for symmetry.
There was a problem hiding this comment.
I have added checks around the revert code.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ankitsinghal
approved these changes
Jul 9, 2024
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Funny, the code with my accidentally pasted URL compiled, and did not even break the code because "http:" got interpreted as a label, and the rest as a comment. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
stoty
added a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit 429d6ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.