Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured #6114

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pankaj72981
Copy link
Contributor

HADOOP-18810 added io.compression.codec.zstd.buffersize in core-default.xml with default value as 0, so default value of hbase.io.compress.zstd.buffersize will become 0 instead of ZSTD_BUFFER_SIZE_DEFAULT (256 * 1024) when not configured in hbase-site.xml.

…hbase.io.compress.zstd.buffersize is not configured
@pankaj72981 pankaj72981 requested review from apurtell and Apache9 July 23, 2024 14:27
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 4s master passed
+1 💚 compile 0m 43s master passed
+1 💚 checkstyle 0m 18s master passed
+1 💚 spotbugs 0m 47s master passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 compile 0m 41s the patch passed
+1 💚 javac 0m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 18s the patch passed
+1 💚 spotbugs 0m 58s the patch passed
+1 💚 hadoopcheck 10m 43s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
29m 58s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6114/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6114
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux e406412b7e32 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 21ebd2a
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6114/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 15s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 4m 57s master passed
+1 💚 compile 1m 0s master passed
+1 💚 javadoc 0m 51s master passed
+1 💚 shadedjars 9m 12s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 15s the patch passed
+1 💚 compile 0m 39s the patch passed
+1 💚 javac 0m 39s the patch passed
+1 💚 javadoc 0m 26s the patch passed
+1 💚 shadedjars 7m 31s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 1m 55s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 6m 23s hbase-compression-zstd in the patch passed.
39m 15s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6114/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6114
Optional Tests javac javadoc unit compile shadedjars
uname Linux 559583c71ddd 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 21ebd2a
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6114/1/testReport/
Max. process+thread count 887 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6114/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@vineet4008 vineet4008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankaj72981 pankaj72981 merged commit 73f2710 into apache:master Jul 25, 2024
1 check passed
pankaj72981 added a commit that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (#6114)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
pankaj72981 added a commit to pankaj72981/hbase that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (apache#6114)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
pankaj72981 added a commit that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (#6114) (#6121)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
pankaj72981 added a commit that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (#6114) (#6121)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
(cherry picked from commit c6e819e)
pankaj72981 added a commit that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (#6114) (#6121)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
(cherry picked from commit c6e819e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants