-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28389 HBase backup yarn queue parameter ignored #6131
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
This PR for branch master and branch-3. |
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java
Show resolved
Hide resolved
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java
Show resolved
Hide resolved
Also could you please share how this PR was tested and which all commands were covered? I am not sure if writing a UT would be straightforward, if possible that would be great! |
@NihalJain Thanks for your review. @DieterDP-ng has verified "Setting the queue through the configuration does work.", and the changes here is also simple and clear. Besides, the UT for this part is not easy to implement. Could you give me some suggestions? |
Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 9dccc67)
https://issues.apache.org/jira/browse/HBASE-28389