-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active master #6136
Conversation
@@ -80,6 +80,8 @@ message OpenRegionRequest { | |||
repeated RegionOpenInfo open_info = 1; | |||
// the intended server for this RPC. | |||
optional uint64 serverStartCode = 2; | |||
// Master active time as fencing token | |||
optional int64 initiating_master_active_time = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some duplicate file under hbase-protocol module also? Do we need to update there as well ?
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failed tests seem related? |
|
60c10de
to
84a8d1f
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
84a8d1f
to
1f67327
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
1f67327
to
e0db4eb
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Failing tests are working on local. |
…res (#1) * HBASE-28690 added masterStartCode as fencing token for remote procedures * HBASE-28690 comments updated * HBASE-28690 add masterStartCode for RemoteProcedureRequest * HBASE-28690 used master active time for fencing and review comments * HBASE-28690 minor comment addition * HBASE-28690 spotless apply * HBASE-28690 reduce log line length for checkstyle --------- Co-authored-by: ukumawat <ukumawat@salesforce.com>
e0db4eb
to
7980945
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@Umeshkumar9414 Are the test failures related |
The test failure is not related, as it only failed in jdk8 build, which should be a flaky one. Let me merge. |
…eTransition if procedure is initialised by next Active master (apache#6136) Added masterActiveTime as fencing token for remote procedures Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
…res (#1)
HBASE-28690 added masterStartCode as fencing token for remote procedures
HBASE-28690 comments updated
HBASE-28690 add masterStartCode for RemoteProcedureRequest
HBASE-28690 used master active time for fencing and review comments
HBASE-28690 minor comment addition
HBASE-28690 spotless apply
HBASE-28690 reduce log line length for checkstyle