HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152

guluo2016 · 2024-08-13T12:55:34Z

…p while Master is initializing

Apache-HBase · 2024-08-13T14:16:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 47s		master passed
+1 💚	compile	4m 28s		master passed
+1 💚	checkstyle	1m 7s		master passed
+1 💚	spotbugs	2m 36s		master passed
+1 💚	spotless	1m 9s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 25s		the patch passed
+1 💚	compile	4m 55s		the patch passed
+1 💚	javac	4m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 59s		the patch passed
+1 💚	spotbugs	2m 50s		the patch passed
+1 💚	hadoopcheck	16m 16s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	1m 31s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		55m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6152
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 7ba7b5ff330f 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `27f8230`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-03T13:57:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 6s		master passed
+1 💚	compile	3m 8s		master passed
+1 💚	checkstyle	0m 33s		master passed
+1 💚	spotbugs	1m 32s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 56s		the patch passed
+1 💚	compile	3m 9s		the patch passed
+1 💚	javac	3m 9s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 35s		the patch passed
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	hadoopcheck	10m 51s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 41s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		36m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6152
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux afcca7d85409 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3cb4df9`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

guluo2016 · 2024-09-03T14:44:36Z

hbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp

+  HRegion region = null;
+  if (regionName != null) {
+    region = rs.getRegion(regionName);
+  }


We input directly into the browser http://localhost:16030/region.json, without specifying a region name (http://localhost:16030/region.json?name=123456789), we would get NPE in here.

Although this situation does not occur frequently, it is best to handle it.

Apache-HBase · 2024-09-03T17:31:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 1s		master passed
+1 💚	compile	0m 58s		master passed
+1 💚	javadoc	0m 29s		master passed
+1 💚	shadedjars	5m 22s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	0m 58s		the patch passed
+1 💚	javac	0m 58s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	5m 17s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	225m 50s		hbase-server in the patch passed.
		250m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6152
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 1d7a84f7cceb 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3cb4df9`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/2/testReport/
Max. process+thread count	5225 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6152/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-09-04T14:43:49Z

hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp

@@ -47,8 +47,28 @@
 <%@ page import="org.apache.hadoop.hbase.metrics.Histogram" %>
 <%@ page import="java.util.TreeMap" %>
 <%@ page import="org.apache.hadoop.hbase.metrics.impl.HistogramImpl" %>
+
+<jsp:include page="header.jsp">


Why we move this page here? Because we may add some elements in the below code block and it should be placed after header?

Yes, the below code block should be placed after header，as shown below.

If we don't do this, it will display as follows.

…procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d)

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d)

NPE may occur when opening master-status or table.jsp or procedure.js…

27f8230

…p while Master is initializing

Fix NPE when accessing region.jsp without specifying a region name

3cb4df9

guluo2016 commented Sep 3, 2024

View reviewed changes

Apache9 reviewed Sep 4, 2024

View reviewed changes

Apache9 approved these changes Sep 5, 2024

View reviewed changes

Apache9 merged commit 3caaf2d into apache:master Sep 5, 2024
1 check passed

Apache9 pushed a commit that referenced this pull request Sep 5, 2024

HBASE-28778 NPE may occur when opening master-status or table.jsp or …

52eae69

…procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d)

guluo2016 mentioned this pull request Sep 5, 2024

HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (branch-2) #6210

Merged

guluo2016 deleted the hbase_HBASE-28778 branch September 13, 2024 13:44

PDavid mentioned this pull request Dec 13, 2024

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152

HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152

guluo2016 commented Aug 13, 2024

Apache-HBase commented Aug 13, 2024

Apache-HBase commented Sep 3, 2024

guluo2016 Sep 3, 2024

Apache-HBase commented Sep 3, 2024

Apache9 Sep 4, 2024

guluo2016 Sep 5, 2024

HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152

HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152

Conversation

guluo2016 commented Aug 13, 2024

Apache-HBase commented Aug 13, 2024

Apache-HBase commented Sep 3, 2024

guluo2016 Sep 3, 2024

Choose a reason for hiding this comment

Apache-HBase commented Sep 3, 2024

Apache9 Sep 4, 2024

Choose a reason for hiding this comment

guluo2016 Sep 5, 2024

Choose a reason for hiding this comment