-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28793 Update hbase-thirdparty to 4.1.8 #6166
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@@ -77,7 +77,7 @@ protected void addOptions() { | |||
|
|||
@Override | |||
protected void processOptions(CommandLine cmd) { | |||
String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, null); | |||
String testFilterString = cmd.getOptionValue(SHORT_REGEX_ARG, (String) null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simply skip/remove 2nd param as the method anyways return null by default.
ea8b217
to
0477eec
Compare
Thanks @NihalJain for looking into this PR, have updated the MR. |
0477eec
to
b8dbe53
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
+1 LGTM! Please check build failure and update remove staging repo before merging. |
🎊 +1 overall
This message was automatically generated. |
b8dbe53
to
5e25049
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
TestFanOutOneBlockAsyncDFSOutput is passing locally, let me trigger the QA again. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
5e25049
to
c476594
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
HBASE-28793 Update hbase-thirdparty to 4.1.8 Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com> (cherry picked from commit 2785a3e)
Update hbase-thirdparty to 4.1.8.
Added staging repository for compilation and build, will remove it when 4.1.8 is officially released.