Skip to content

HBASE-28580 Revert the deprecation for methods in WALObserver #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

HBASE-28580 Revert the deprecation for methods in WALObserver #6205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/WALObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,25 +56,31 @@
@InterfaceStability.Evolving
public interface WALObserver {
/**
* Called before a {@link WALEdit} is writen to WAL. Do not amend the WALKey. It is
* InterfaceAudience.Private. Changing the WALKey will cause damage.
* @deprecated Since hbase-2.0.0. To be replaced with an alternative that does not expose
* InterfaceAudience classes such as WALKey and WALEdit. Will be removed in
* hbase-3.0.0.
* Called before a {@link WALEdit} is writen to WAL.
* <p>
* The method is marked as deprecated in 2.0.0, but later we abstracted the WALKey interface for
* coprocessors, now it is OK to expose this to coprocessor users, so we revert the deprecation.
* But you still need to be careful while changing {@link WALEdit}, as when reaching here, if you
* add some cells to WALEdit, it will only be written to WAL but no in memstore, but when
* replaying you will get these cells and there are CP hooks to intercept these cells.
* <p>
* See HBASE-28580.
*/
@Deprecated
default void preWALWrite(ObserverContext<? extends WALCoprocessorEnvironment> ctx,
RegionInfo info, WALKey logKey, WALEdit logEdit) throws IOException {
}

/**
* Called after a {@link WALEdit} is writen to WAL. Do not amend the WALKey. It is
* InterfaceAudience.Private. Changing the WALKey will cause damage.
* @deprecated Since hbase-2.0.0. To be replaced with an alternative that does not expose
* InterfaceAudience classes such as WALKey and WALEdit. Will be removed in
* hbase-3.0.0.
* Called after a {@link WALEdit} is writen to WAL.
* <p>
* The method is marked as deprecated in 2.0.0, but later we abstracted the WALKey interface for
* coprocessors, now it is OK to expose this to coprocessor users, so we revert the deprecation.
* But you still need to be careful while changing {@link WALEdit}, as when reaching here, if you
* add some cells to WALEdit, it will only be written to WAL but no in memstore, but when
* replaying you will get these cells and there are CP hooks to intercept these cells.
* <p>
* See HBASE-28580.
*/
@Deprecated
default void postWALWrite(ObserverContext<? extends WALCoprocessorEnvironment> ctx,
RegionInfo info, WALKey logKey, WALEdit logEdit) throws IOException {
}
Expand Down