HBASE-28845 table level wal appendSize and replication source metrics… #6259
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
terrytlu
force-pushed
the
master-HBASE-28845
branch
2 times, most recently
from
baf8457
to
3058da9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
terrytlu
force-pushed
the
master-HBASE-28845
branch
from
3058da9
to
fb25735
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
terrytlu
force-pushed
the
master-HBASE-28845
branch
from
fb25735
to
c96894c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… not correctly shown in /jmx response xx
terrytlu
force-pushed
the
master-HBASE-28845
branch
from
c96894c
to
4bbf647
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 17, 2024
| @@ -260,6 +260,10 @@ public String getQualifierAsString() { | |||
| return qualifierAsString; | |||
| } | |||
|
|
|||
| public String getMetricPrefixTableName() { | |||
There was a problem hiding this comment.
TableName is IA.Public so we'd better not add new method unless you are sure it is useful for everyone.
| @@ -88,7 +88,7 @@ public void incrementAppendSize(TableName tableName, long size) { | |||
| if (tableAppendSizeCounter == null) { | |||
| // Ideally putIfAbsent is atomic and we don't need a branch check but we still do it to avoid | |||
| // expensive string construction for every append. | |||
| String metricsKey = String.format("%s.%s", tableName, APPEND_SIZE); | |||
| String metricsKey = String.format("%s.%s", tableName.getMetricPrefixTableName(), APPEND_SIZE); | |||
There was a problem hiding this comment.
So the problem here is that, if we have ':' in th table name, it can not be displayed in jmx?
But this is still a breaking change... do we have other ways to obtain the metrics beside jmx? Do these ways also require that there is no ':' in the metrics name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found 2 metrics did not display in the /jmx http interface response, table level wal appendSize and table level replication source.
I suspect it's because the metric name contains a colon :
after modify the table name string to "Namespace_$namespace_table_$table, the metric really display correctly in the /jmx response