HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6361
+102
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
PDavid
commented
Oct 9, 2024
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
PDavid
commented
Oct 10, 2024
Comment on lines
-53
to
-56
| if (firstRowCell == null || this.prefix == null) return true; | ||
| if (filterAllRemaining()) return true; | ||
| if (firstRowCell == null || this.prefix == null) { | ||
| return true; | ||
| } | ||
| if (filterAllRemaining()) { | ||
| return true; | ||
| } | ||
| int length = firstRowCell.getRowLength(); | ||
| if (length < prefix.length) return true; |
There was a problem hiding this comment.
These are actually not strictly required to resolve the ticket. Just the checkstyle report contained these warnings:
(blocks) NeedBraces: 'if' construct must use '{}'s.
(blocks) NeedBraces: 'if' construct must use '{}'s.
(blocks) NeedBraces: 'if' construct must use '{}'s.
(blocks) NeedBraces: 'if' construct must use '{}'s.
There was a problem hiding this comment.
Actually this if looks buggy.
If the firstRowCell is lexicographically smaller than the prefix, then we still want to provide the hint, regardless of the key length.
We can probably just drop this, I believe that the compare later will also handle this case.
This was supposed to be an optization, but it is not relevant when we provide hints, and in fact hurts performance.
Please fix and also add test cases for this.
PDavid
commented
Oct 10, 2024
| @@ -40,7 +43,6 @@ public class TestPrefixFilter { | |||
| static final char FIRST_CHAR = 'a'; | |||
| static final char LAST_CHAR = 'e'; | |||
| static final String HOST_PREFIX = "org.apache.site-"; | |||
| static final byte[] GOOD_BYTES = Bytes.toBytes("abc"); | |||
There was a problem hiding this comment.
This is also a bit unrelated - an unused constant field.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
please remove the colon from the commit message / PR description |
added 3 commits
October 14, 2024 14:37
(blocks) NeedBraces: 'if' construct must use '{}'s.
PDavid
changed the title
PDavid
force-pushed
the
HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT
branch
from
09fc843
to
02ed23a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stoty
requested changes
Oct 15, 2024
Comment on lines
-53
to
-56
| if (firstRowCell == null || this.prefix == null) return true; | ||
| if (filterAllRemaining()) return true; | ||
| if (firstRowCell == null || this.prefix == null) { | ||
| return true; | ||
| } | ||
| if (filterAllRemaining()) { | ||
| return true; | ||
| } | ||
| int length = firstRowCell.getRowLength(); | ||
| if (length < prefix.length) return true; |
There was a problem hiding this comment.
Actually this if looks buggy.
If the firstRowCell is lexicographically smaller than the prefix, then we still want to provide the hint, regardless of the key length.
We can probably just drop this, I believe that the compare later will also handle this case.
This was supposed to be an optization, but it is not relevant when we provide hints, and in fact hurts performance.
Please fix and also add test cases for this.
This comment has been minimized.
This comment has been minimized.
stoty
reviewed
Oct 18, 2024
| @@ -77,7 +77,7 @@ public boolean filterRowKey(Cell firstRowCell) { | |||
| if ((!isReversed() && cmp > 0) || (isReversed() && cmp < 0)) { | |||
| passedPrefix = true; | |||
| } | |||
| filterRow = (!isReversed() && cmp > 0) || (isReversed() && cmp < 0); | |||
| filterRow = (!isReversed() && cmp > 0) || (isReversed() && cmp != 0); | |||
There was a problem hiding this comment.
Completely agree. But this fixes the previously failing TestFilter.testPrefixFilterWithReverseScan unit test. 😅
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.