HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6433

NihalJain · 2024-11-04T07:34:38Z

Backport HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6218 / HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #5607

…pache#6218) (apache#5607) - Also handle changes required for hadoop-2 assembly Signed-off-by: Istvan Toth <stoty@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit b6394b1) (cherry picked from commit 2537690)

NihalJain · 2024-11-04T09:30:26Z

Verified following on branch-2.6

Built code and ran hbase-shell unit tests locally
Started hbase master in standalone, did basic shell sanity
Started hbase-rest in standalone, did basic rest sanity
Started hbase-thrift in standalone, ran thrift examples

Apache-HBase · 2024-11-06T14:22:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 15s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 32s		branch-2.6 passed
+1 💚	compile	8m 39s		branch-2.6 passed
+1 💚	spotless	0m 56s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 27s		the patch passed
+1 💚	compile	8m 11s		the patch passed
+1 💚	javac	8m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	19m 47s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 20s		The patch does not generate ASF License warnings.
		51m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6433
Optional Tests	dupname asflicense javac codespell detsecrets xmllint spotless hadoopcheck compile
uname	Linux 671ac231d74f 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `4c9356c`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-06T18:25:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 21s		branch-2.6 passed
+1 💚	compile	2m 56s		branch-2.6 passed
+1 💚	javadoc	4m 10s		branch-2.6 passed
+1 💚	shadedjars	7m 14s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 51s		the patch passed
+1 💚	compile	2m 57s		the patch passed
+1 💚	javac	2m 57s		the patch passed
+1 💚	javadoc	4m 9s		the patch passed
+1 💚	shadedjars	6m 3s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	250m 39s	/patch-unit-root.txt	root in the patch failed.
		294m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6433
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a341a1f09a4e 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `4c9356c`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/testReport/
Max. process+thread count	4883 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-06T20:50:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 32s		branch-2.6 passed
+1 💚	compile	1m 42s		branch-2.6 passed
+1 💚	javadoc	2m 54s		branch-2.6 passed
+1 💚	shadedjars	5m 14s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 19s		the patch passed
+1 💚	compile	1m 45s		the patch passed
+1 💚	javac	1m 45s		the patch passed
-0 ⚠️	javadoc	1m 30s	/results-javadoc-javadoc-root.txt	root generated 10 new + 90 unchanged - 10 fixed = 100 total (was 100)
+1 💚	shadedjars	5m 11s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	406m 39s		root in the patch passed.
		439m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6433
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d773d49b0258 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `4c9356c`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/testReport/
Max. process+thread count	8038 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-06T22:21:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 25s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 43s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 56s		branch-2.6 passed
+1 💚	compile	2m 48s		branch-2.6 passed
+1 💚	javadoc	5m 7s		branch-2.6 passed
+1 💚	shadedjars	7m 48s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 12s		the patch passed
+1 💚	compile	2m 23s		the patch passed
+1 💚	javac	2m 23s		the patch passed
+1 💚	javadoc	3m 21s		the patch passed
+1 💚	shadedjars	6m 47s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	476m 55s	/patch-unit-root.txt	root in the patch failed.
		530m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6433
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 725c6ad338f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `4c9356c`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/testReport/
Max. process+thread count	4812 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-11-07T11:35:09Z

Failure are unrelated and do not fail consistently with this change!

NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024

This comment has been minimized.

Sign in to view

NihalJain merged commit 432e548 into apache:branch-2.6 Nov 7, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6433

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6433

NihalJain commented Nov 4, 2024

NihalJain commented Nov 4, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 6, 2024

Apache-HBase commented Nov 6, 2024

Apache-HBase commented Nov 6, 2024

Apache-HBase commented Nov 6, 2024

NihalJain commented Nov 7, 2024

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6433

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6433

Conversation

NihalJain commented Nov 4, 2024

NihalJain commented Nov 4, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 6, 2024

Apache-HBase commented Nov 6, 2024

Apache-HBase commented Nov 6, 2024

Apache-HBase commented Nov 6, 2024

NihalJain commented Nov 7, 2024