HBASE-29402: Comprehensive key management for encryption at rest #7111
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Also committing WIP L1 cache implementation - Added JavaDoc
|
Working on significant changes. |
Rolling back the feature to have multiple active keys per (cust, ns) and be able to select one at random.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The PR is too big to review... Is it possible to create sub tasks for this feature and let's commit it to a feature branch first? |
|
Created feature branch: https://github.com/apache/hbase/tree/HBASE-29368-key-management-feature |
haridsv
changed the base branch from
master
to
HBASE-29368-key-management-feature
|
Updated the base branch of the PR to the feature branch. |
@Apache9 Thanks for the interest! Though the change looks good, a lot of those are boilerplate sort of code that follows existing patterns. Also I aimed for 100% test coverage so a lot of the change is just test coverage. The feature is already being implemented in a phased manner and the current PR has the bare minimum to make it functional. Splitting further won't look organic and will complicate testing by quite a bit. However, considering that we now have the feature branch, I can now raise PRs more frequently for smaller units of changes. Please feel free to let me know if there is anything else I can do to make it easier. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Jenkins test this please |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Triggered new build |
virajjasani
merged commit 211132c
into
apache:HBASE-29368-key-management-feature
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 participants
JIRA: HBASE-29402
Please refer to parent JIRA: HBASE-29368 for details and a design doc.