-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29226 Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 #7233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Backports #6783 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…nsume hbase-thridparty having the new jetty 12 ee8 module
… add details on why we need violations
… - Discrepancy between Jetty 9 and Jetty 12 when setting the base resource to a path containing ..
ed14fed to
4f67bd4
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find a detailed summary of all changes as below:
Dependencies
hbase-shaded-jettyi.e. Jetty 9 withhbase-shaded-jetty-12-plus-coreandhbase-shaded-jetty-12-plus-ee8i.e. Jetty 12 EE8servlet.api.versionto4.0.1tomcat.jasper.versionto9.0.107Code Adjustments
org.eclipse.jetty.ee8etc. as per Jetty 12HandlerCollectionwithHandler.SequencesetResourceBase()withsetBaseResourceAsPath(). Also, passinglogDirpath in canonical format as otherwise, we get404in case we have\..\in static path...jetty/jetty.project#12958MultiExceptionwithExceptionUtil.MultiExceptioninHttpServer.java.webServer.getHandlers()with new return type:ArraytoListConstraintwithServletConstraintLogLevelExceptionUtils.javato handle HTML error response for log levels asconnection.getResponseMessage()now returns error code as string in message and hence causes test failure otherwisejavaxas xsd files atjavax/servlet/resourcescome viaorg.apache.hbase.thirdparty:hbase-shaded-jetty-12-ee8Test Adjustments
checkBindAddress()to callserver.start()elsetestBindAddress()fails with NPE. Verified doing same without Jetty 12 works as well.JSON.parse()withnew JSON().fromJSON()andJSON.toString()withnew JSON().toJSON()".."to""as it fails withIllegalArgumentExceptionotherwiseMockHttpApiRulewhere we replaceAbstractHandlerwithHandler.Abstractand adjust code based on new interface.webdefaults.xml. Need to see if still needed.References