Skip to content

HBASE-29615 Update Small tests description wrt reuseForks in docs #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stoty merged 2 commits into from
Sep 22, 2025
+4 −7
Merged

HBASE-29615 Update Small tests description wrt reuseForks in docs #7335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a1f58
HBASE-29615 Update Small tests description wrt reuseForks in docs
stoty Sep 22, 2025
f8a5179
also update Javadoc in HBaseTestingUtil
stoty Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2293,8 +2293,7 @@ public HRegionServer getRSForFirstRegionInTable(TableName tableName)
/**
* Starts a <code>MiniMRCluster</code> with a default number of <code>TaskTracker</code>'s.
* MiniMRCluster caches hadoop.log.dir when first started. It is not possible to start multiple
* MiniMRCluster instances with different log dirs. MiniMRCluster is only to be used from when the
* test is run from a separate VM (i.e not in SmallTests)
* MiniMRCluster instances with different log dirs.
* @throws IOException When starting the cluster fails.
*/
public MiniMRCluster startMiniMapReduceCluster() throws IOException {
Expand All @@ -2308,8 +2307,7 @@ public MiniMRCluster startMiniMapReduceCluster() throws IOException {
/**
* Starts a <code>MiniMRCluster</code>. Call {@link #setFileSystemURI(String)} to use a different
* filesystem. MiniMRCluster caches hadoop.log.dir when first started. It is not possible to start
* multiple MiniMRCluster instances with different log dirs. MiniMRCluster is only to be used from
* when the test is run from a separate VM (i.e not in SmallTests)
* multiple MiniMRCluster instances with different log dirs.
* @param servers The number of <code>TaskTracker</code>'s to start.
* @throws IOException When starting the cluster fails.
*/
Expand Down
5 changes: 2 additions & 3 deletions src/main/asciidoc/_chapters/developer.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,12 +1308,11 @@ to put on your new HBase test case.

.Categorizing Tests
Small Tests (((SmallTests)))::
_Small_ test cases are executed in a shared JVM and each test suite/test class should
_Small_ test cases are executed in separate JVM and each test suite/test class should
run in 15 seconds or less; i.e. a link:https://en.wikipedia.org/wiki/JUnit[junit test fixture], a java object made
up of test methods, should finish in under 15 seconds, no matter how many or how few test methods
it has. These test cases should not use a minicluster as a minicluster starts many services,
most unrelated to what is being tested. Multiple start/stops may leak resources or just overwhelm
the single JVM context.
most unrelated to what is being tested.

Medium Tests (((MediumTests)))::
_Medium_ test cases are executed in separate JVM and individual test suites or test classes or in
Expand Down