Skip to content

HBASE-29797 Should not create wal directory when creating WAL instanc… #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Apache9 merged 3 commits into from
Jan 8, 2026
Merged

HBASE-29797 Should not create wal directory when creating WAL instanc… #7589

Apache9 merged 3 commits into from
Jan 8, 2026

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jan 5, 2026

…e (#7585)

(cherry picked from commit add6f22)

@Apache9
HBASE-29797 Should not create wal directory when creating WAL instance (
51a056d 
apache#7585)

Signed-off-by: Charles Connell <cconnell@apache.org>
(cherry picked from commit add6f22)
@Apache9 Apache9 self-assigned this Jan 5, 2026
@Apache9 Apache9 added the backport This PR is a back port of some issue or issues already committed to master label Jan 5, 2026
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 3m 29s branch-2 passed
+1 💚 compile 6m 5s branch-2 passed
+1 💚 checkstyle 1m 14s branch-2 passed
+1 💚 spotbugs 9m 0s branch-2 passed
+1 💚 spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 3m 7s the patch passed
+1 💚 compile 6m 4s the patch passed
+1 💚 javac 6m 4s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 12s the patch passed
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 9m 17s the patch passed
+1 💚 hadoopcheck 16m 58s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
62m 17s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7589
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname Linux 576b1b6f8099 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c9ea53d
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 179 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 51s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 2m 36s branch-2 passed
+1 💚 compile 1m 35s branch-2 passed
+1 💚 javadoc 1m 46s branch-2 passed
+1 💚 shadedjars 4m 40s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 1m 35s the patch passed
+1 💚 javac 1m 35s the patch passed
+1 💚 javadoc 1m 39s the patch passed
+1 💚 shadedjars 4m 38s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 246m 5s /patch-unit-root.txt root in the patch failed.
273m 42s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #7589
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8dfb2a84fe4a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c9ea53d
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/testReport/
Max. process+thread count 3809 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 26s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 44s branch-2 passed
+1 💚 compile 3m 9s branch-2 passed
+1 💚 javadoc 3m 38s branch-2 passed
+1 💚 shadedjars 7m 28s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 4m 11s the patch passed
+1 💚 compile 3m 24s the patch passed
+1 💚 javac 3m 24s the patch passed
+1 💚 javadoc 2m 54s the patch passed
+1 💚 shadedjars 8m 37s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 338m 27s /patch-unit-root.txt root in the patch failed.
386m 13s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7589
Optional Tests javac javadoc unit shadedjars compile
uname Linux 32a3e1c9794d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c9ea53d
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/testReport/
Max. process+thread count 3496 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 23s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 6s branch-2 passed
+1 💚 compile 2m 35s branch-2 passed
+1 💚 javadoc 3m 25s branch-2 passed
+1 💚 shadedjars 6m 51s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 13s the patch passed
+1 💚 compile 2m 41s the patch passed
+1 💚 javac 2m 41s the patch passed
+1 💚 javadoc 2m 59s the patch passed
+1 💚 shadedjars 7m 2s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 463m 40s /patch-unit-root.txt root in the patch failed.
505m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #7589
Optional Tests javac javadoc unit shadedjars compile
uname Linux fd6e4797b652 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c9ea53d
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/testReport/
Max. process+thread count 3424 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7589/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jan 8, 2026

Tried locally, the failed UTs passed for me.

@Apache9 Apache9 merged commit 5a5f273 into apache:branch-2 Jan 8, 2026
1 check failed
Apache9 added a commit that referenced this pull request Jan 8, 2026
@Apache9
HBASE-29797 Should not create wal directory when creating WAL instance (
0814737 
#7585)(#7589)

Signed-off-by: Charles Connell <cconnell@apache.org>
(cherry picked from commit add6f22)
Apache9 added a commit that referenced this pull request Jan 8, 2026
@Apache9
HBASE-29797 Should not create wal directory when creating WAL instance (
8ccccb5 
#7585)(#7589)

Signed-off-by: Charles Connell <cconnell@apache.org>
(cherry picked from commit add6f22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Apache9 Apache9

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Apache9 @Apache-HBase