HBASE-29727 Introduce a String pool for repeating filename, region and cf string fields in BlockCacheKey (#7477) (#7503)

[wchevreuil]

• Resolved conflict

Change-Id: I05a7dfb7d73cf50e76fc9ca260f4dacad12cd2c5

• adding extra log to understand the flakey ut errors

Change-Id: I3bc75f878d04262ac11e6f4a8ef4d743720b8701

• some UT refinements to avoid flakeyness

Change-Id: Ia0117bf3b0e8e4424fdfcb7e9e3e6bf65769c05c

---

Change-Id: I25eaf24ee4acc5d55d100591426ee17ffe81a7a1

[Apache9]

Please run spotless to fix the problem...

IIRC on other branches, the spotless issue was fixed by later commits from other issues...

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 1s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	buf	0m 1s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 36s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 48s		branch-2.6 passed
+1 💚	compile	5m 8s		branch-2.6 passed
+1 💚	checkstyle	1m 33s		branch-2.6 passed
+1 💚	spotbugs	5m 51s		branch-2.6 passed
+1 💚	spotless	1m 12s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 35s		the patch passed
+1 💚	compile	5m 34s		the patch passed
+1 💚	cc	5m 34s		the patch passed
-0 ⚠️	javac	4m 40s	/results-compile-javac-hbase-server.txt	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 4s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 2 new + 23 unchanged - 1 fixed = 25 total (was 24)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	5m 56s		the patch passed
+1 💚	hadoopcheck	25m 11s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	hbaseprotoc	1m 36s		the patch passed
+1 💚	spotless	1m 6s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		68m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7596
Optional Tests	dupname asflicense codespell detsecrets spotbugs xmllint spotless cc buflint bufcompat hbaseprotoc javac checkstyle compile hadoopcheck hbaseanti
uname	Linux c8c5b364990d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / 4ccd792
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 26s		branch-2.6 passed
+1 💚	compile	1m 27s		branch-2.6 passed
+1 💚	javadoc	0m 39s		branch-2.6 passed
+1 💚	shadedjars	6m 30s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	1m 27s		the patch passed
+1 💚	javac	1m 27s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed
+1 💚	shadedjars	6m 22s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 30s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	216m 48s		hbase-server in the patch passed.
		246m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7596
Optional Tests	unit javac javadoc compile shadedjars
uname	Linux a2d1bcfb81f9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / 4ccd792
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/testReport/
Max. process+thread count	3348 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s		branch-2.6 passed
+1 💚	compile	1m 7s		branch-2.6 passed
+1 💚	javadoc	0m 35s		branch-2.6 passed
+1 💚	shadedjars	5m 37s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s		the patch passed
+1 💚	compile	1m 9s		the patch passed
+1 💚	javac	1m 9s		the patch passed
+1 💚	javadoc	0m 35s		the patch passed
+1 💚	shadedjars	5m 31s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 26s		hbase-protocol-shaded in the patch passed.
-1 ❌	unit	231m 12s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		257m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7596
Optional Tests	unit javac javadoc compile shadedjars
uname	Linux 72f2e0380ed1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / 4ccd792
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/testReport/
Max. process+thread count	2960 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 29s		branch-2.6 passed
+1 💚	compile	1m 25s		branch-2.6 passed
+1 💚	javadoc	0m 38s		branch-2.6 passed
+1 💚	shadedjars	6m 47s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	1m 25s		the patch passed
+1 💚	javac	1m 25s		the patch passed
+1 💚	javadoc	0m 36s		the patch passed
+1 💚	shadedjars	6m 43s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 32s		hbase-protocol-shaded in the patch passed.
-1 ❌	unit	245m 24s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		277m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7596
Optional Tests	unit javac javadoc compile shadedjars
uname	Linux 6c4676dd6a09 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / 4ccd792
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/testReport/
Max. process+thread count	3210 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7596/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.