-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29820 Bump the syntax of velocity template to align with veloci… #7614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0c206c0 to
5f173ea
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The test failures seems unrelated. |
stoty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
|
@stoty thank you for the review. Do you want me to create a separate PR for branch-2. I didnot try cherry-picking this to branch-2 yet. |
|
Yes, let's follow the process and make a backport PR @mnpoonia , |
|
@stoty I tried cherrypicking and it was a clean cherry pick to branch-2 and branch-2.6. Should i still create a separate PR or its not needed. |
|
I would suggest creating a branch-2 PR to make sure that it works with the maven plugins used there. |
|
@stoty Gentle reminder. Please look into it when you get time. |
…ty 2.x syntax
HBASE-29820