Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jan 11, 2026

No description provided.

@Apache9 Apache9 requested a review from stoty January 11, 2026 15:53
@Apache9 Apache9 self-assigned this Jan 11, 2026
@Apache9
Copy link
Contributor Author

Apache9 commented Jan 11, 2026

JUnit6 has been released, we should speed up for upgrading to junit 5.

In this PR I also implemented a HBaseParameterizedTemplateProvider for simulating the parameterized test in JUnit4, which will be easier for us to migrate from junit4 to junit5.

@stoty PTAL.

Thanks.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the good start to migrate module by module at a time. I could help with the migration if needed.

// get parameters
Method method;
try {
method = testClass.getDeclaredMethod("parameters");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: IMO defining an annotation for the parameter provider method would be more in line with the Junit API than requiring a hardcoded method name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I think a hard coded method name is enough for our usage in HBase.

In JUnit5, we need to use @MethodSource("<method_name>") to reference the method, which does not have compile time check either...

We can improve this later.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 15s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 48s master passed
+1 💚 compile 0m 44s master passed
+1 💚 javadoc 0m 37s master passed
+1 💚 shadedjars 7m 46s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 4m 34s the patch passed
+1 💚 compile 1m 3s the patch passed
+1 💚 javac 1m 3s the patch passed
+1 💚 javadoc 0m 42s the patch passed
+1 💚 shadedjars 8m 18s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 3m 10s hbase-common in the patch passed.
+1 💚 unit 1m 57s hbase-asyncfs in the patch passed.
35m 40s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7615/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7615
Optional Tests javac javadoc unit shadedjars compile
uname Linux 214c4dd2d138 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 799d9e9
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7615/2/testReport/
Max. process+thread count 650 (vs. ulimit of 30000)
modules C: hbase-common hbase-asyncfs U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7615/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 25s master passed
+1 💚 compile 1m 30s master passed
+1 💚 checkstyle 0m 32s master passed
+1 💚 spotbugs 1m 30s master passed
+1 💚 spotless 1m 15s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 58s the patch passed
+1 💚 compile 1m 43s the patch passed
+1 💚 javac 1m 43s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 42s the patch passed
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 1m 50s the patch passed
+1 💚 hadoopcheck 13m 8s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 1m 2s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 23s The patch does not generate ASF License warnings.
44m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7615/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7615
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname Linux 63bc07e70980 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 799d9e9
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 82 (vs. ulimit of 30000)
modules C: hbase-common hbase-asyncfs U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7615/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 119c0ce into apache:master Jan 12, 2026
1 check passed
Apache9 added a commit that referenced this pull request Jan 12, 2026
Signed-off-by: Istvan Toth <stoty@apache.org>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 119c0ce)
Apache9 added a commit that referenced this pull request Jan 12, 2026
Signed-off-by: Istvan Toth <stoty@apache.org>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 119c0ce)
Apache9 added a commit that referenced this pull request Jan 12, 2026
Signed-off-by: Istvan Toth <stoty@apache.org>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 119c0ce)
Apache9 added a commit that referenced this pull request Jan 12, 2026
Signed-off-by: Istvan Toth <stoty@apache.org>
Reviewed-by: Liu Xiao <liuxiao2103@qq.com>
(cherry picked from commit 119c0ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants