Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23171 Ensure region state error messages include server making report (branch-2.1) #777

Merged
merged 1 commit into from
Oct 30, 2019
Merged

HBASE-23171 Ensure region state error messages include server making report (branch-2.1) #777

merged 1 commit into from
Oct 30, 2019

Conversation

busbey
Copy link
Contributor

@busbey busbey commented Oct 30, 2019

No description provided.

@busbey busbey requested a review from saintstack October 30, 2019 05:42
@binlijin
Copy link
Contributor

+1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 13s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
💚 mvninstall 5m 31s branch-2.1 passed
💚 compile 0m 55s branch-2.1 passed
💚 checkstyle 1m 31s branch-2.1 passed
💚 shadedjars 4m 18s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 34s branch-2.1 passed
💙 spotbugs 2m 56s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 2m 55s branch-2.1 passed
_ Patch Compile Tests _
💚 mvninstall 5m 7s the patch passed
💚 compile 0m 57s the patch passed
💚 javac 0m 57s the patch passed
💚 checkstyle 1m 26s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 21s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 21m 45s Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
💚 javadoc 0m 33s the patch passed
💚 findbugs 3m 7s the patch passed
_ Other Tests _
💚 unit 200m 32s hbase-server in the patch passed.
💚 asflicense 0m 25s The patch does not generate ASF License warnings.
261m 34s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-777/1/artifact/out/Dockerfile
GITHUB PR #777
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 51af2e7626df 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-777/out/precommit/personality/provided.sh
git revision branch-2.1 / 3f12d50
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-777/1/testReport/
Max. process+thread count 4692 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-777/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey busbey merged commit 1b7afcc into apache:branch-2.1 Oct 30, 2019
@busbey
Copy link
Contributor Author

busbey commented Oct 30, 2019

thanks for the review!

@busbey busbey deleted the HBASE-23171 branch October 30, 2019 14:00
saintstack
saintstack reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Great.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -991,8 +991,8 @@ void checkOnlineRegionsReportForMeta(final ServerName serverName, final Set<byte
final RegionInfo hri = getMetaRegionFromName(regionName);
if (hri == null) {
if (LOG.isTraceEnabled()) {
LOG.trace("Skip online report for region=" + Bytes.toStringBinary(regionName) +
" while meta is loading");
LOG.trace("Skip online report for region={} while meta is loading from server={}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

region= is redundant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is server= ... smile. Who else would be making a report here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would the server making the report be redundant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If regionName is redundant then why does getMetaRegionFromName take it as an argument?

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -1035,7 +1035,8 @@ void checkOnlineRegionsReport(final ServerStateNode serverNode, final Set<byte[]
" but state has otherwise AND NO procedure is running");
}
} catch (UnexpectedStateException e) {
LOG.warn(regionNode.toString() + " reported unexpteced OPEN: " + e.getMessage(), e);
LOG.warn("{} reported unexpteced OPEN: {} sever={}", regionNode.toString(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busbey @binlijin @Apache-HBase @saintstack