HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 #945

ZhaoBQ · 2019-12-17T03:39:06Z

HBASE-23585

…returns 200

binlijin

+1

ZhaoBQ · 2019-12-17T05:13:59Z

thanks for the review @binlijin

Apache-HBase · 2019-12-17T07:09:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 55s	branch-1 passed
+1 💚	compile	0m 40s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	0m 43s	branch-1 passed with JDK v1.7.0_242
+1 💚	checkstyle	1m 31s	branch-1 passed
+1 💚	shadedjars	2m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	0m 43s	branch-1 passed with JDK v1.7.0_242
+0 🆗	spotbugs	2m 50s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 47s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 59s	the patch passed
+1 💚	compile	0m 40s	the patch passed with JDK v1.8.0_232
+1 💚	javac	0m 40s	the patch passed
+1 💚	compile	0m 44s	the patch passed with JDK v1.7.0_242
+1 💚	javac	0m 44s	the patch passed
+1 💚	checkstyle	1m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 18s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 31s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	0m 41s	the patch passed with JDK v1.7.0_242
+1 💚	findbugs	2m 54s	the patch passed
		_ Other Tests _
-1 ❌	unit	162m 51s	hbase-server in the patch failed.
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		204m 7s

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestZKLessSplitOnCluster
	hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
	hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/1/artifact/out/Dockerfile
GITHUB PR	#945
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e573d458b1d9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-945/out/precommit/personality/provided.sh
git revision	branch-1 / `28673f0`
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/1/testReport/
Max. process+thread count	4070 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ZhaoBQ · 2019-12-26T06:24:32Z

The failed UT looks unrelated to this patch. @binlijin , can you merge this pull requests, thanks!

HorizonNet · 2019-12-30T13:12:19Z

I just kicked off a new build to see if we just hit some flaky tests.

saintstack · 2020-01-02T22:54:14Z

@HorizonNet 's attempt failed for some reason. Retry.

Apache-HBase · 2020-01-03T01:51:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	10m 0s	branch-1 passed
+1 💚	compile	0m 49s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	0m 58s	branch-1 passed with JDK v1.7.0_242
+1 💚	checkstyle	2m 15s	branch-1 passed
+1 💚	shadedjars	3m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	0m 55s	branch-1 passed with JDK v1.7.0_242
+0 🆗	spotbugs	3m 40s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 36s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 51s	the patch passed with JDK v1.8.0_232
+1 💚	javac	0m 51s	the patch passed
+1 💚	compile	0m 55s	the patch passed with JDK v1.7.0_242
+1 💚	javac	0m 55s	the patch passed
+1 💚	checkstyle	2m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 49s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 37s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	0m 50s	the patch passed with JDK v1.7.0_242
+1 💚	findbugs	3m 50s	the patch passed
		_ Other Tests _
-1 ❌	unit	126m 57s	hbase-server in the patch failed.
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		176m 30s

Reason	Tests
Failed junit tests	hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/3/artifact/out/Dockerfile
GITHUB PR	#945
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d76c390e2a3e 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-945/out/precommit/personality/provided.sh
git revision	branch-1 / `19b35d2`
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/3/testReport/
Max. process+thread count	3953 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-945/3/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ZhaoBQ · 2020-01-03T03:15:28Z

Thanks @HorizonNet @saintstack. Now there is another different UT failed......

saintstack · 2020-01-03T05:42:26Z

Signed-off-by: Jan Hentschel <janh@apache.org>
Signed-off-by: stack <stack@apache.org>

HorizonNet · 2020-01-03T10:44:07Z

@saintstack You already merged this one, right? Should we close this PR?

saintstack · 2020-01-03T15:05:26Z

@HorizonNet Looks like I forgot to click the merge button the second time. Done now.

…returns 200 (#945) Signed-off-by: Jan Hentschel <janh@apache.org> Signed-off-by: stack <stack@apache.org>

…returns 200 (apache#945) Signed-off-by: Jan Hentschel <janh@apache.org> Signed-off-by: stack <stack@apache.org>

…returns 200 (apache#945) Signed-off-by: Jan Hentschel <janh@apache.org> Signed-off-by: stack <stack@apache.org> (cherry picked from commit 3a4f389)

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always …

6c99c80

…returns 200

binlijin approved these changes Dec 17, 2019

View reviewed changes

ZhaoBQ changed the title ~~HBase-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200~~ HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 Dec 17, 2019

saintstack approved these changes Jan 2, 2020

View reviewed changes

saintstack merged commit 6b940ae into apache:branch-1 Jan 3, 2020

asfgit pushed a commit that referenced this pull request Jan 3, 2020

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always …

3a4f389

…returns 200 (#945) Signed-off-by: Jan Hentschel <janh@apache.org> Signed-off-by: stack <stack@apache.org>

Reidddddd pushed a commit to Reidddddd/hbase that referenced this pull request Jul 30, 2020

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always …

fb17a69

…returns 200 (apache#945) Signed-off-by: Jan Hentschel <janh@apache.org> Signed-off-by: stack <stack@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 #945

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 #945

ZhaoBQ commented Dec 17, 2019 •

edited

Loading

binlijin left a comment

ZhaoBQ commented Dec 17, 2019

Apache-HBase commented Dec 17, 2019

ZhaoBQ commented Dec 26, 2019

HorizonNet commented Dec 30, 2019

saintstack commented Jan 2, 2020

Apache-HBase commented Jan 3, 2020

ZhaoBQ commented Jan 3, 2020

saintstack commented Jan 3, 2020

HorizonNet commented Jan 3, 2020

saintstack commented Jan 3, 2020

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 #945

HBASE-23585 MetricsRegionServerWrapperImpl.getL1CacheHitCount always returns 200 #945

Conversation

ZhaoBQ commented Dec 17, 2019 • edited Loading

binlijin left a comment

Choose a reason for hiding this comment

ZhaoBQ commented Dec 17, 2019

Apache-HBase commented Dec 17, 2019

ZhaoBQ commented Dec 26, 2019

HorizonNet commented Dec 30, 2019

saintstack commented Jan 2, 2020

Apache-HBase commented Jan 3, 2020

ZhaoBQ commented Jan 3, 2020

saintstack commented Jan 3, 2020

HorizonNet commented Jan 3, 2020

saintstack commented Jan 3, 2020

ZhaoBQ commented Dec 17, 2019 •

edited

Loading