Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23635 Reduced number of Checkstyle violations in hbase-mapreduce #981

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

HorizonNet
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 10 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 5m 57s master passed
+1 💚 compile 0m 25s master passed
+1 💚 checkstyle 0m 21s master passed
+1 💚 shadedjars 5m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 18s master passed
+0 🆗 spotbugs 0m 51s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 50s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 27s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 checkstyle 0m 19s hbase-mapreduce: The patch generated 0 new + 0 unchanged - 35 fixed = 0 total (was 35)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 5m 5s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 17m 18s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 17s the patch passed
+1 💚 findbugs 0m 56s the patch passed
_ Other Tests _
+1 💚 unit 16m 46s hbase-mapreduce in the patch passed.
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
67m 46s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-981/1/artifact/out/Dockerfile
GITHUB PR #981
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 53360e04e69d 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-981/out/precommit/personality/provided.sh
git revision master / 85ecdd1
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-981/1/testReport/
Max. process+thread count 5262 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-981/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. Looks great.

@HorizonNet HorizonNet merged commit ab97665 into apache:master Jan 3, 2020
@HorizonNet HorizonNet deleted the HBASE-23635 branch January 3, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants