Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: app-jvm.yml support for international name aliases #1376

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Feature: app-jvm.yml support for international name aliases #1376

merged 4 commits into from
Dec 2, 2023

Conversation

Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Dec 2, 2023

我按自己的理解添加了jvm的国际化描述,不知道翻译是否准确到位,如果有更好的建议希望可以指出~
image

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍LGTM!

@tomsun28
Copy link
Contributor

tomsun28 commented Dec 2, 2023

正确的没有问题👍
@all-contributors please add @Calvin979 for code

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Correct, no problem👍
@all-contributors please add @Calvin979 for code

Copy link
Contributor

@hertzbeat

@Calvin979 already contributed before to code

@tomsun28 tomsun28 merged commit 3aedee3 into apache:master Dec 2, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants