Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix nginx collect http deadlock error #1476

Merged
merged 1 commit into from
Jan 9, 2024
Merged

bugfix nginx collect http deadlock error #1476

merged 1 commit into from
Jan 9, 2024

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Jan 8, 2024

What's changed?

due not close the http response or request.abort() to returen the connection to http pool, http client pool may casue the dead lock

image

stack.log

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28
bugfix nginx collect http deadlock error
04f4768 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 added the bugfix label Jan 8, 2024
@tomsun28 tomsun28 added this to the 1.4.4 milestone Jan 8, 2024
a-little-fool
a-little-fool approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@a-little-fool a-little-fool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your correction. I didn't take this into consideration. 🚀～

@a-little-fool a-little-fool merged commit e9913d7 into master Jan 9, 2024
2 checks passed
@a-little-fool a-little-fool deleted the bugfix-http-lock branch January 9, 2024 12:25
tomsun28 added a commit that referenced this pull request Jan 16, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
99d4608 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
52fc99e 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
65cc79b 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
76e5de3 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
f5ede44 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
bb32633 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
36562d4 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
6277631 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
db183d6 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@tomsun28
bugfix nginx collect http deadlock error (#1476)
d3e553d 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 mentioned this pull request Apr 7, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-little-fool a-little-fool a-little-fool approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tomsun28 @a-little-fool