Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix webhook notice error #1504

Merged
merged 3 commits into from
Jan 20, 2024
Merged

bugfix webhook notice error #1504

merged 3 commits into from
Jan 20, 2024

Conversation

Carpe-Wang
Copy link
Contributor

@Carpe-Wang Carpe-Wang commented Jan 20, 2024 •
edited
Loading

What's changed?

fixes #1503

  • 具体做法是在2-WebhookTemplate中如果属性为null直接不展示
  • 并且其他两个类只是多删除了回撤换行

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Jan 20, 2024
@tomsun28 tomsun28 changed the title Bugfix1503 bugfix webhook notice error Jan 20, 2024
tomsun28
tomsun28 approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 merged commit 55b4d7b into master Jan 20, 2024
2 checks passed
@tomsun28 tomsun28 deleted the bugfix1503 branch January 20, 2024 15:55
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
3857127 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
16995e5 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang @tomsun28
bugfix webhook notice error (#1504)
0fa7168 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
970b56a 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Carpe-Wang @tomsun28
bugfix webhook notice error (#1504)
10b01e2 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
c40603c 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
857aa6e 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
414d0d4 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
bugfix webhook notice error (#1504)
60421bb 
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] <webhook notice error>
2 participants
@Carpe-Wang @tomsun28