HIVE-28327: Missing null-check in TruncDateFromTimestamp (Seonggon Na…

…mgung, reviewed by Denys Kuzmenko, Shohei Okumiya) Closes #5300
apache · Jul 19, 2024 · a61af0a · a61af0a
1 parent 4835968
commit a61af0a
Show file tree

Hide file tree

Showing 3 changed files with 569 additions and 426 deletions.
diff --git a/itests/src/test/resources/testconfiguration.properties b/itests/src/test/resources/testconfiguration.properties
@@ -307,7 +307,6 @@ mr.query.files=\
   udf_count.q,\
   udf_using.q,\
   uniquejoin.q,\
-  vector_udf_trunc.q,\
   windowing_windowspec.q
 
 encrypted.query.files=\

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java
@@ -126,7 +126,9 @@ public void evaluate(VectorizedRowBatch batch) throws HiveException {
         for (int j = 0; j != n; j++) {
           int i = sel[j];
           outputIsNull[i] = inputIsNull[i];
-          truncDate(inputColVector, outputColVector, i);
+          if (!inputIsNull[i]) {
+            truncDate(inputColVector, outputColVector, i);
+          }
         }
       } else {
         System.arraycopy(inputIsNull, 0, outputIsNull, 0, n);