Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Aug 12, 2020

What changes were proposed in this pull request?

This PR proposes to upgrade Guava to 27 in Hive 2.3 branch.

Why are the changes needed?

When trying to upgrade Guava in Spark, found the following error. A Guava method became package-private since Guava version 20. So there is incompatibility with Guava versions > 19.0.

sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.IllegalAccessError: tried to access method com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; from class org.apache.hadoop.hive.ql.exec.FetchOperator
	at org.apache.hadoop.hive.ql.exec.FetchOperator.<init>(FetchOperator.java:108)
	at org.apache.hadoop.hive.ql.exec.FetchTask.initialize(FetchTask.java:87)
	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:541)
	at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
	at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
	at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
	at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)

Does this PR introduce any user-facing change?

Yes. This upgrades Guava to 27.

How was this patch tested?

Built Hive locally.

@viirya
Copy link
Member Author

viirya commented Aug 12, 2020

cc @sunchao Thanks.

@sunchao
Copy link
Member

sunchao commented Aug 12, 2020

@viirya I wonder if we can create another PR targeting branch-2. It seems there is minimum conflict between branch-2.3 and branch-2 for this, and the testing seems to be working for branch-2 (see this as example).

@viirya
Copy link
Member Author

viirya commented Aug 12, 2020

@sunchao OK, let me try it. But I think by the end the 2.3.8 should be from branch-2.3, right?

@sunchao
Copy link
Member

sunchao commented Aug 12, 2020

Yes that's right. If tests pass on branch-2 we can cherry-pick this to branch-2.3 and probably commit it directly, I think.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Oct 12, 2020
@github-actions github-actions bot closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants