Skip to content

Conversation

@sunchao
Copy link
Member

@sunchao sunchao commented Oct 29, 2020

What changes were proposed in this pull request?

Two changes combined in this PR:

  • backport HIVE-23323 to enable better parallelism for qtests
  • Add Jenkinsfile

Why are the changes needed?

Without a Jenkinsfile we won't trigger CI for new PRs against the branch-3.1. This allows ppl to test their code.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

@sunchao sunchao changed the title Branch 3.1 jenkins HIVE-24331: Add Jenkinsfile for branch-3.1 Oct 29, 2020
@sunchao
Copy link
Member Author

sunchao commented Oct 30, 2020

seems the TestMiniDruidKafkaCliDriver is timing out and we need https://issues.apache.org/jira/browse/HIVE-19170

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you so much, @sunchao !

@dongjoon-hyun
Copy link
Member

Interesting. It seems that we need more patches.

There are 1 new tests failing, 62 existing failing and 249 skipped.

@sunchao
Copy link
Member Author

sunchao commented Oct 30, 2020

I think these failures are not related to the PR - at least the PR itself gives us a baseline for the test results.

@sunchao
Copy link
Member Author

sunchao commented Oct 30, 2020

cc @kgyrtkirk could you take a look? thanks.

@kgyrtkirk
Copy link
Member

thank you @sunchao for working on this! these failures were most likely there before as well. I haven't noticed anything problematic (with the test execution stuff)
+1

@dongjoon-hyun
Copy link
Member

Thank you, @kgyrtkirk and @sunchao .
Then, can we merge this and proceed to fix the bug based on this CI failures?

@sunchao
Copy link
Member Author

sunchao commented Nov 2, 2020

Thanks @kgyrtkirk . I'll backport HIVE-23323 and HIVE-19170 separately to the branch-3.1 to retain a clean commit history, and then create a new PR with just the jenkins file change and merge it.

@sunchao
Copy link
Member Author

sunchao commented Nov 2, 2020

Merged. Thanks @kgyrtkirk for the review.

@sunchao sunchao deleted the branch-3.1-jenkins branch November 2, 2020 21:08
@dongjoon-hyun
Copy link
Member

Thank you so much!

amanraj2520 pushed a commit to amanraj2520/hive that referenced this pull request Dec 7, 2022
amanraj2520 pushed a commit to amanraj2520/hive that referenced this pull request Dec 8, 2022
udaynpusa pushed a commit to mapr/hive that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants