-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-24331: Add Jenkinsfile for branch-3.1 #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
seems the |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you so much, @sunchao !
|
Interesting. It seems that we need more patches. |
|
I think these failures are not related to the PR - at least the PR itself gives us a baseline for the test results. |
|
cc @kgyrtkirk could you take a look? thanks. |
|
thank you @sunchao for working on this! these failures were most likely there before as well. I haven't noticed anything problematic (with the test execution stuff) |
|
Thank you, @kgyrtkirk and @sunchao . |
|
Thanks @kgyrtkirk . I'll backport HIVE-23323 and HIVE-19170 separately to the branch-3.1 to retain a clean commit history, and then create a new PR with just the jenkins file change and merge it. |
3b3a766 to
9e67f19
Compare
|
Merged. Thanks @kgyrtkirk for the review. |
|
Thank you so much! |
What changes were proposed in this pull request?
Two changes combined in this PR:
Why are the changes needed?
Without a Jenkinsfile we won't trigger CI for new PRs against the branch-3.1. This allows ppl to test their code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests