HIVE-24324: Remove deprecated API usage from Avro #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @szehon-ho @aihuaxu could you review this? thanks. |
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
aihuaxu
approved these changes
Nov 17, 2020
Member
Author
|
Thanks @aihuaxu ! Test failures unrelated. Merging to branch-2.3 now. |
udaynpusa
pushed a commit
to mapr/hive
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This backports #1621 to branch-2.3.
This mainly replace
JsonProperties.getJsonPropwithJsonProperties.getObjectProp.Note that there's one place in
SchemaToTypeInfowhere we explicitly callgetIntValueto forbid string as precision/scale values (see HIVE-7174). To retain the old behavior, we check if the returned object is integer type, and if not, return a default 0 followingJsonNodeimplementation.Why are the changes needed?
JsonProperties#getJsonProphas been marked as deprecated in Avro 1.8 and removed since Avro 1.9. This replaces the API usage for this withgetObjectPropwhich doesn't leak Json node from jackson. This will help downstream apps to depend on Hive while using higher version of Avro, and also help Hive to upgrade Avro version itself.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.