-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-25098: Upgrade thrift from 0.13.0 to 0.14.1 #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mattmccline-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the new 0.14.1 methods such as getMinSerializedSize, do we understand:
- why the method was added?
- Is it possible the Thrift library call it on our objects now? What is the expected behavior? Is there a way to indicate not implemented like returning -1
mattmccline-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the seperate standalone-metastore Hive project? It specifies the libthrift.version
mattmccline-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the separate standalone-metastore Hive project? It specifies the libthrift.version, too.
Yes seperate standalone-metastore also specifies the libthrift.version. I have bumped the version for that also. |
This methods got added as part of interface changes in thrift 0.14.1. We don't understand and use this methods as of now. So i will return -1; |
mattmccline-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What changes were proposed in this pull request?
Thrift version bump from 0.13.0 to 0.14.1
Why are the changes needed?
To fix existing security issued in 0.13.0 https://nvd.nist.gov/vuln/detail/CVE-2020-13949
Does this PR introduce any user-facing change?
No
How was this patch tested?
Since this is version upgrade only. If all the existing test case cleared then we are good to go.