HIVE-27885 : Cast decimal from string with space without digits before dot returns NULL #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e dot returns NULL
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
ramesh0201
approved these changes
Nov 19, 2023
|
+1 LGTM |
aturoczy
reviewed
Nov 20, 2023
There was a problem hiding this comment.
with the .0000 is applicable in SQL standard?
.00 is more likely a Culture Info and it is bit US specific.
cc: @ayushtkn @abstractdog
|
@ayushtkn any concerns with this or are we good to merge? |
|
yep, no objections from my side. go ahed!!! |
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…e dot returns NULL (apache#4876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support valid decimal which has only scale.
Why are the changes needed?
Incorrect results
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Yes, added testcase in cast2.q file